-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components: Increase default sizes to 36px height #39397
Labels
[Package] Components
/packages/components
[Type] Tracking Issue
Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Comments
mirka
added
[Package] Components
/packages/components
[Type] Tracking Issue
Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
labels
Mar 11, 2022
mirka
changed the title
Components: Increasing default sizes to 36px height
Components: Increase default sizes to 36px height
Mar 11, 2022
This was referenced Mar 11, 2022
This was referenced Apr 26, 2022
1 task
This was referenced Jul 14, 2022
4 tasks
Closing in favor of #46741 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Package] Components
/packages/components
[Type] Tracking Issue
Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
⏸️ On hold while we first focus on #41973
To clean up size inconsistencies between form components (e.g. button, input, select), we'd first like to standardize on a default height of 36px. This matches the default height of the Button component, and is an appropriate size for most contexts. It is also an acceptable "interim" size to be at before we introduce the larger 40px size variants.
Migration plan
__next36pxDefaultSize
prop, but do not add a formaldeprecate()
warning. (This prop will be used as an internal feature flag to coordinate the rollout of the size changes. Externally, the size changes will land without a formal deprecation.)size
prop, opting into__next36pxDefaultSize
should only affect the"default"
variant.size = "__unstable-large"
)Components to migrate
Stage 1
These are the "primitive" components that need to be addressed first. Adding 36px variants to these will allow other components built on them to provide 36px variants.
Stage 2
These are the higher-level components built using the primitive components. Those marked with
*
do not require a__next36pxDefaultSize
prop at all and can land the size changes immediately, since they are already in an inconsistent state.Out of scope
The text was updated successfully, but these errors were encountered: