InputControl: Add flag for larger default size #40622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #39397
What?
Adds the temporary prop
__next36pxDefaultSize
to opt into the new 36px height default size.Dependent components
This also technically adds
__next36pxDefaultSize
support to any higher-level component that forwards props ontoInputControl
.NumberControl
, I checked locally that it looks as expected. I don't think it's worth adding the prop to Storybook at the moment — I'd prefer waiting until the TS conversion + Knobs-to-Controls rewrite.UnitControl
, I'll do a separate PR to adjust paddings and add "official" support for it via TypeScript. (Which will also add it to Storybook) UnitControl: Add flag for larger default size #40627Why?
As part of the effort to move toward consistent component sizes.
How?
Details of the migration plan are written in the original issue #39397.
Testing Instructions
npm run storybook:dev
InputControl
. By setting the__next36pxDefaultSize
control totrue
, the height of thedefault
size variant should increase to 36px. All other size variants are unchanged.Screenshots or screencast
Old default
New default (opt-in for now)