Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move template part replacement flow to the transform menu #42425

Open
jameskoster opened this issue Jul 14, 2022 · 5 comments
Open

Move template part replacement flow to the transform menu #42425

jameskoster opened this issue Jul 14, 2022 · 5 comments
Labels
[Block] Template Part Affects the Template Parts Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

The template part replacement flow is currently initiated from the ellipsis menu on the block toolbar.

Screenshot 2022-07-14 at 11 50 55

Conceptually this is closely related to transforms, and so could be moved to that menu instead, something like:

cc @Mamaduka

@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. Needs Dev Ready for, and needs developer efforts [Block] Template Part Affects the Template Parts Block labels Jul 14, 2022
@carolinan carolinan assigned carolinan and unassigned carolinan Sep 6, 2022
@carolinan
Copy link
Contributor

Should this implementation be moved to the blockswitcher component?

@Mamaduka
Copy link
Member

Mamaduka commented Sep 6, 2022

@carolinan, that's correct. Primarily in BlockSwitcherDropdownMenu component.

@carolinan carolinan self-assigned this Sep 7, 2022
@carolinan
Copy link
Contributor

One of the reasons why I was hesitating to do that is that the BlockSwitcherDropdownMenu is in the block-editor package.
We will be checking if every loaded block is a template part, even though template parts are only available in the site editor? 🤔

@carolinan carolinan removed their assignment Jan 4, 2023
@annezazu
Copy link
Contributor

annezazu commented Apr 6, 2023

Noting that this came up as part of the FSE Outreach Program's Build a Block Theme exploration:

Switching a Header Template. What about using the Transform To menu to switch a Reusable block to another Reusable block, and one type of pattern with another similar type. Be it Header, Footer etc. Being able to easily transform from one type of Header pattern to another.

While I noted the current "replace" flow and the work being done here #44582, I wanted to connect the dots to this specific part of the feedback.

@paaljoachim
Copy link
Contributor

paaljoachim commented Apr 7, 2023

Thanks Anne!

Btw
Here is another approach:
A cycle between patterns icon in the Toolbar. I am also suggesting a broader solution.
#44581 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants