-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Surface related patterns in the template inspector #44582
Comments
love this! |
Plus one. Love it! Let's make it happen. (Though maybe I'd have a separator between the inspector header and patterns, perhaps even a subheading for the patterns). |
Noting that this matches this prior feedback that came in: #39864 For consistency/to consolidate, I'm going to close mine out but wanted to be sure that the inability to do this has been noted as a pain point in the past. |
I'm going to investigate this. I remember having seen a mention or a sketch for having the ability to switch whole sections in the zoom-out view as well (or was it the site editor?), though I can't find it now. I guess both things are related. Would anyone have a link/sketch handy? |
I am reading through prior art and ran into this use case:
Letting this here as another potential place to surface patterns a set of blocks can be transformed into. |
This is still a WIP, but yes I would say that both are related. There's also the shuffle concept for templateLock:contentOnly blocks which is similar. Indeed this could drive the transforms you mention. IE if you select a heading and a paragraph the transform menu could expose patterns that are made up of those content blocks specifically. |
Raw prototype at #45285 It should be enough to clarify some questions. |
I believe the other solution to add a cycle icon in the Pattern Group block toolbar to show various patterns directly in the canvas is an even better way to go: Because: |
@oandregal checking in here to ensure this is still on your list to move forward as it's been a few months since active work was completed on the PR. |
Oh, thanks for checking. This slip through the cracks, sorry about that. I had #45285 and #47507, but I no longer know whether they are in a good state to be merged or how long they'll require. I have some upcoming AFK and some threads I'm involved in, so I'd rather free this one up for anyone to take. I may be able to come back at this in a couple of weeks if I manage to wrap up the other work. |
@jameskoster I'm not sure we are capturing this specific flow in that issue. I think the templates sidebar is an ideal place to get something going. Could be a collapsible panel with patterns of a relevant category to start. |
Not sure about using the inspector for this as I could accomplish the same thing via inserter. Could we add a "recommended" or "switch" category at the top of the patterns inserter that will work for all scenarios? e.g. replacing similar patterns |
@SaxonF we could do both. Is there a specific reason you had in mind for not using the Inspector? |
Yeah, this doesn't take away from other flows that might become, in time, more intuitive. But right now the inspector is completely empty and missed opportunity for discovering existing relevant patterns in context. |
This is very important for TT4. Right now it's easy to swap from the post editor, but that is not good for certain templates like archive.html. This will surface those patterns so much better. |
Adding this back to 6.4 after seeing the above note about this being important for TT4, which is a blessed task. |
If we're concerned about performance, we could potentially add these to a panel, have it closed initially perhaps as well. At least until #54999 is explored further. Also, we could set a max number of rendered previews with a “View all” button to open the modal, similar to how the pattern explorer is set within the inserter. |
I've made a start on this: #55091 |
With just over a week until beta 1, punting this out of 6.5 as the associated PR hasn't yet been merged and this wasn't a strong focus for the release. |
When editing a template or template part, it would be nice to find associated patterns in the Inspector.
For template parts that might look something like:
It could work the same for templates too, but we'd need a way for patterns to be associated with specific templates. For example it wouldn't be helpful to be suggested 404 patterns while editing the Archive template.
The text was updated successfully, but these errors were encountered: