Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPalette: Transparent checkered pattern doesn't adhere to 4px grid #42687

Closed
mirka opened this issue Jul 25, 2022 · 3 comments
Closed

ColorPalette: Transparent checkered pattern doesn't adhere to 4px grid #42687

mirka opened this issue Jul 25, 2022 · 3 comments
Labels
[Package] Components /packages/components

Comments

@mirka
Copy link
Member

mirka commented Jul 25, 2022

What problem does this address?

The background pattern isn't adhering to the 4px grid system (the squares are 25px). This can cause the pattern to be cut off at rather awkward positions when the container size adheres to the 4px grid:

The checkered pattern being cut off awkwardly in a color picker popover

(Encountered in #41900)

What is your proposed solution?

Make the square size adhere to the 4px grid, for example 24px.
@mirka mirka added the [Package] Components /packages/components label Jul 25, 2022
@richtabor
Copy link
Member

Related #42278

@ciampo
Copy link
Contributor

ciampo commented Jul 26, 2022

Make the square size adhere to the 4px grid, for example 24px.

This sounds like the correct and most sensible solution

@mirka mirka changed the title ColorPicker: Transparent checkered pattern doesn't adhere to 4px grid ColorPalette: Transparent checkered pattern doesn't adhere to 4px grid Jul 26, 2022
@brookewp brookewp mentioned this issue Oct 26, 2022
Merged
@mirka
Copy link
Member Author

mirka commented Oct 26, 2022

Fixed by #45295

@mirka mirka closed this as completed Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] Components /packages/components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mirka @ciampo @richtabor