Update color palette popover style #41900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
Needs Design Feedback
|
Size Change: +95 B (0%) Total Size: 1.26 MB
ℹ️ View Unchanged
|
javierarce
added
the
Needs Figma Update
|
Nice! I've just tested it and it looks good to me ✨ |
|
I agree. The changes looks good to me as well! |
|
We could try to implement the solution proposed in #41937 (comment) — what do you think, @mirka ? |
|
Yes, I'll look into this within the next few days and report back 👍 |
Progress update
|
mirka
force-pushed
the
update/color-palette-popover
branch
from
ce18f29
to
a190d78
Compare
|
@jameskoster Ok I'm done ✅
☝️ By the way, do we care that the checkered pattern for the "transparent" color is now cut off at an awkward place? The |
|
Thanks @mirka ! :) The padding is a bit awkward here since we switched to tabs:
But I think that's something to fix in the tabpanel component (#42320).
Agreed. For now I don't think it's a deal-breaker. |
|
Sidetrack comment...Related to the Color Panels. |
|
Coming back to this one (thank you for the energy and attention to details!) — I like the padding around the swatches, but the larger padding around the current color spot feels more awkward now, with the same 2px radius looking extra out of place. The panel was originally designed to have that be edge-to-edge, like this:
I believe the previous non-standard padding is something we arrived at exactly because edge-to-edge turned out to be non-trivial to implement. Is that still the case or could we revisit that? CC: @ciampo in case you recall details. |
|
Oh yes, that would be a nice enhancement. |
@mirka 's work with #42595 may make some of this easier, but we'd still need to take a closer look |
|
@jasmussen I'm looking into getting the awkward padding resolved and also get the current color button be edge-to-edge, like in your mockup. One follow-up question: How do we want the edge-to-edge current color button to look when it's under the Solid/Gradient tab switcher? Edge-to-edge with no top-margin? |
|
Thank you!
That's an excellent question. When there's no switcher, this is the previous flow mocked up:
I have an older discarded variant here that I don't love, which nevertheless affords an item above the edge to edge swatch:
My preference, however, would be to always keep the current indicator as the first item, as seen in the mockups for this pattern addition:
That's one of the reasons why I've preferred the segmented control. It is secondary to the main color... a property, so to speak, rather than a distinct tab. |
|
Potentially also relevant, #39452 which details iterations to the duotone configuration, which also keeps the preview/current duotone at the top. |
4 tasks
|
Started a tracking issue here: #43014 I love that design! Funnily, to me that flipped order makes the tab panel model even more "correct" 😆 I think the fundamental difference between a tab panel and a radio is that, a radio is for a "value" that is to be submitted or persisted, whereas a tab panel is just a temporary way to expand/collapse information, much like an accordion. In theory you should be able to expand all the panels into a vertical list and it should still make sense. The flipped order you propose makes a very logical hierarchy to me:
Whereas previously it was kind of murky:
So that leads me to a few more questions:
|
Good question. That could be interesting. It seems like that might also line up with some of the hierarchy proposed for gradients in the global styles inspector: Imprecise mockup, but something along these lines:
That would also answer your second question, as it appears the order in the Global Styles mockup I found already orders it current color/gradient first, followed by configuration, then swatches. If you have a moment to look, @pablohoneyhoney, I'd love your thoughts. |
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some small style adjustments that I think improve the appearance of the palette popover.
Changes
Still todo