Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No drop indicator appears when dragging a file into an empty post or block list #44064

Open
talldan opened this issue Sep 12, 2022 · 1 comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Sep 12, 2022

Description

Related #32880, #42365, #42722

Dropping a file does work, but there's no indicator to show that it will work.

This seems to happen because there are no blocks in the post. The 'Type / to choose a block' text is part of a React component called the DefaultBlockAppender, so the usual block drop indicators don't work (and they wouldn't be the right thing to show anyway).

There's also a similar situation when trying to drag a block or a file into an empty group block, so it may be worth coming up with one solution for empty block lists.

Step-by-step reproduction instructions

Empty post

  1. Create a new post
  2. Try dragging a file into the post

Expected: There's some indication on the screen that dropping the file will work

Empty group block

  1. Add a group block
  2. Try dragging another block or image into the group

Expected: There's some indication on the screen that dropping the block will work

Screenshots, screen recording, code snippet

No response

Environment info

  • Brave / Mac OS

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 13, 2022
@talldan talldan removed the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

1 participant