Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop target marker not shown when there is only one paragraph #42365

Closed
msurdi opened this issue Jul 12, 2022 · 2 comments
Closed

Drag and drop target marker not shown when there is only one paragraph #42365

msurdi opened this issue Jul 12, 2022 · 2 comments
Labels
[Block] Image Affects the Image Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended

Comments

@msurdi
Copy link
Contributor

msurdi commented Jul 12, 2022

Description

When there's only one paragraph, the blue image drop marker is not being shown, which makes it unclear where the image is going to land when dropped.

Step-by-step reproduction instructions

  1. Write a post consisting of just a title and a single line (paragraph) of text
  2. Drag and drop an image, try to drop it before or after the paragraph. It's unclear where it is going to land.

Screenshots, screen recording, code snippet

I'm attaching two videos. In the first one you can see the blue marker is not displayed, thus not making easy to tell where (and if) the image is going to drop.

In the second one you can see it working between paragraphs, but still doesn't show before the first one, or after the last one.

no-marker.mp4
marker.mp4

Environment info

Gutenberg: v13.6.0
Theme: Twenty Twenty Two
WordPress version: 6.0-RC4-53438

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@kathrynwp kathrynwp added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Jul 12, 2022
@kathrynwp
Copy link

I was able to replicate this with:

WordPress: 6.0
Gutenberg: 13.6.0
Theme: Twenty Twenty-Two

With Gutenberg deactivated, the issue is not present and the blue image drop marker does appear as expected.

@simison simison added the [Feature] Drag and Drop Drag and drop functionality when working with blocks label Jul 13, 2022
@talldan
Copy link
Contributor

talldan commented Sep 12, 2022

This is fixed as of #43135.

There's one situation where is still doesn't work, which is the default block appender that appears when first creating a post (the text that says "Type / to choose a block"). There's also #42722 that may end up being a reasonable way to fix that.

I'll close this and report that problem in another issue (#44064).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants