Fix drag and drop indicator before first block and after last block #43135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
requested review from
ntwb,
nerrad,
ajitbohra and
ellatrix
as code owners
talldan
added
[Type] Regression
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Aug 11, 2022
There was a problem hiding this comment.
The fix works well in my tests.
✅ I can see a drop indicator before the first block and after the last block.
✅ Now, I can also drop files and blocks on those positions.
The drop indicators inside the gallery do not always show up for the first and the last block. But probably can be handled separately.
Screencast
CleanShot.2022-08-11.at.10.08.42.mp4
talldan
deleted the
fix/drag-and-drop-indicator-before-first-block-and-after-last-block
branch
I am also seeing this, it seems that for horizontal layouts like the gallery the indicator does not appear before the first block (left of it). It is showing after the last block however. cc @talldan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reported in #43127, Partial fix for #32880
Fixes the drag and drop insertion point indicator at the start and end of block lists, which had regressed again.
This time adds e2e tests to prevent future regressions.
I did try writing these tests in Playwright, but the drag and drop utilities there are not quite as fully-featured as puppeteer's.
How?
The fix is easy, just changes some boolean logic around how the in-between inserter renders.
I think the regression keeps happening because contributors are trying to optimize performance but don't realise they're introducing a bug. Hopefully the added comments and tests will prevent this in future.
Testing Instructions
Note - if you drag too far (outside the bounds of the block list) dropping a block won't work and the insertion point won't be visible. This is already captured as an issue in #32880. It's a more complicate issue to fix.
Also worth testing:
Screenshots or screencast
Before
Kapture.2022-08-11.at.12.53.43.mp4
After
Kapture.2022-08-11.at.12.51.41.mp4