-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks to margin / padding visualizer #44700
Comments
@mtias did you have any thoughts on whether the visualiser should appear for the duration of the time that you are moused over the control, or just appear briefly as it does now when adjusting sizes? |
Not quite sure, would need to get a feel for it. |
it seems a little odd just having a brief view of the visualiser when mousing over to match the same temporary view when adjusting: mouseover-brief.mp4seems to work better to keep the visualiser in place the whole time moused over the control: hover-permanent.mp4 |
A PoC PR here for the mouseover part of this. |
Agree, that works really well. 👍 |
Indeed, let's keep it visible during the whole interaction. |
I think this is mostly done now, though perhaps one thing that's missing is that the visualizer doesn't show on focus of the padding or margin controls. |
@talldan have added focus here |
That's great! Nice work, I'll close this issue as completed 🎉 |
One thing to keep in mind — I mentioned in another PR that it'd be good to explore a more systematic approach to interactions that should / could hide the toolbar like "is typing" does. Direct manipulations of inspector control tools come to mind in general, but also canvas resizing. |
@mtias there is some more work being done around this here |
Is #46192 the best issue to track the work? |
I think so, and have now updated the title to better reflect that. |
It'd be nice if hovering or focusing on the margin / padding / gap tools would display the overlays even if you are not dragging the value handles. cc @talldan .
It also seems like we should try to not render the toolbar while showing the overlays (at least margin). It should feel a bit more like engaging "is typing" to avoid the toolbar rendering through:
The text was updated successfully, but these errors were encountered: