Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore a more systematic approach to interactions that should / could hide the block toolbar #46192

Open
scruffian opened this issue Nov 30, 2022 · 2 comments
Assignees
Labels
[Feature] Inspector Controls The interface showing block settings and the controls available for each block [Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Type] Discussion For issues that are high-level and not yet ready to implement. [Type] Enhancement A suggestion for improvement.

Comments

@scruffian
Copy link
Contributor

scruffian commented Nov 30, 2022

What problem does this address?

When manipulating things via the Inspector Controls, the Block Toolbar can often obscure the block in a frustrating way. This is evident for the spacing visualizer: #45131

However the same is also true for other manipulations that happen in the Block Inspector, and also things like canvas resizing.

What is your proposed solution?

We should look for a more systematic approach to defining when the Block Toolbar should be hiden/shown.

@scruffian scruffian added the [Feature] Inspector Controls The interface showing block settings and the controls available for each block label Nov 30, 2022
@glendaviesnz glendaviesnz self-assigned this Nov 30, 2022
@jasmussen
Copy link
Contributor

Would love to see this happen also during drag and drop events. For example I might have a paragraph selected, showing its block toolbar, and when I drag an image from my desktop to be above the paragraph, the toolbar could fade out until I've added the image.

@glendaviesnz glendaviesnz changed the title Inspector Controls: Hide the Block Toolbar when Inspector Controls are focussed Explore a more systematic approach to interactions that should / could hide the block toolbar Dec 7, 2022
@draganescu draganescu added Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement. [Feature] UI Components Impacts or related to the UI component system [Type] Discussion For issues that are high-level and not yet ready to implement. labels Dec 12, 2022
@talldan
Copy link
Contributor

talldan commented Mar 29, 2023

Just a note that this was fixed for the visualizers. There are new showBlockInterface and hideBlockInterface actions for hiding the toolbar.

I'm extending it to also hide the block outline in #45056.

At the moment these actions are locked/private apis as there's a lot of overlap with the startTyping/stopTyping actions that do the same thing. We need to figure out how to consolidate the two APIs.

There's no reason not to start using it in a few more places though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inspector Controls The interface showing block settings and the controls available for each block [Feature] UI Components Impacts or related to the UI component system Needs Design Feedback Needs general design feedback. [Type] Discussion For issues that are high-level and not yet ready to implement. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants