-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Button Hover Color options on Button Block #4543
Comments
Could we just have a rule of whatever color, the hover should be a little darker? |
I think the hover color should be a little darker than base color. |
@monika-12 yes I agree and let's get this worked on now we have design feedback. |
|
@karmatosed do you know if this has been deployed? I cannot find any docs about hover for buttons in Gutenberg. |
Hey I am rechecking this issue. As can be seen hover has not yet been added. Kjell linked to this issue (right above) |
Is there any chance to have an option to add customized color in button hover color! For example, I want to add different hover colors rather than the light, darker version of the primary button color. ultimate blocks: https://ultimateblocks.com/improved-button-block/ I really appreciate any help you can provide. |
Thank you for adding your comment @Gtarafdar |
Ahh. Thanks a lot. I was waiting for a long. Because only for that feature I have to use another addon. Any ETA @paaljoachim, my brother. |
Thanks for the ping @paaljoachim. I am currently working on adding block support for custom colors along with UI refinements around that. This will be a great use case to trial that new functionality. |
@mtias This is actually not covered in that issue. In #43088 there is only a solution to add the default styling for pseudo-elements, not a solution to change pseudo-elements styling in Gutenberg on the (for example) |
Running WordPress 6.2 and latest Gutenberg plugin. #43088 allows me to set default button elements styling but I cannot change individual buttons in the admin of the editor. |
Hello @mtias , as you have said, it should be covered by #43088. And that issue seems merged with 6.2. But unfortunately, I failed to find the feature as we have been looking for four years in WP 6.2. :( no button hover styling option in the editing panel. |
I will ping |
Yes, I think this issue needs to be reopened. #43088 only adds the ability to change the hover styles for buttons via theme.json. If memory serves, I believe we need design input as to how to properly surface the controls in the UI for the end user. |
There is an issue I believe where @jasmussen and @jameskoster have been experimenting with hover effects. It looks like I found the main issue: Here are various other associated issues I came across as I was searching. Outline button does not take on the theme.json styles of the filled button Hover effect color not fully covered in block editor link control search item Hover color over image block |
Thanks for compiling those! I wonder if now that we also have box shadow controls, those should also be considered for hover effects. But I digress. I'm happy to work on the UI for this if we have design consensus. |
Thanks a lot @paaljoachim. Appreciate that. |
I talked about this with @richtabor today, and he advised to start off with the same way we are implementing it for the link element on Global Styles and extend that to the button: I went to check, and I don't think we have space for the hover tab, we would need to change the component to add the arrows, right? |
The control hierarchy would be to pick between "Default" or "Hover". Then select the colors for Text and Background (Background could have "Solid" and "Gradient" fills)—but there shouldn't be two tab components on top of each other. 🤔 |
Does it seem a bit restrictive to enable state management only on specific controls? 🤔 I feel like continuing to explore #38277 might reveal fertile ground. |
I agree. This isn't quite in a place to move forward with development. |
This is being explored holistically as part of #38277. Let's close this to maintain focus on standardizing interactive states across the board. |
+1 |
it's been 84 years |
85 |
Enhancement Overview
Add Hover options for button like hover background hover color and hover text color.
Expected Behavior
There is no option to add hover color on button so there should be option for Background Hover Color and Hover Text Color.
Screenshots / Video
The text was updated successfully, but these errors were encountered: