Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] can reach toolbar items with arrow keys after pressing alt+F10 #45588

Closed
github-actions bot opened this issue Nov 7, 2022 · 3 comments · Fixed by #46634
Closed

[Flaky Test] can reach toolbar items with arrow keys after pressing alt+F10 #45588

github-actions bot opened this issue Nov 7, 2022 · 3 comments · Fixed by #46634
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

can reach toolbar items with arrow keys after pressing alt+F10

Test path

/test/e2e/specs/editor/various/toolbar-roving-tabindex.spec.js

Errors

[2022-11-07T14:52:31.837Z] Test passed after 1 failed attempt on upgrade/react-18-pure.
[2022-11-17T11:10:41.515Z] Test passed after 1 failed attempt on upgrade/react-18-pure.
[2022-11-18T13:03:43.530Z] Test passed after 1 failed attempt on upgrade/react-18-pure-with-react-native-upgrade.
[2022-11-24T14:20:44.807Z] Test passed after 1 failed attempt on upgrade/react-18-pure.
[2022-11-27T17:30:08.767Z] Test passed after 1 failed attempt on upgrade/react-18-pure.
[2022-11-28T11:46:11.263Z] Test passed after 1 failed attempt on upgrade/react-18-pure.
[2022-11-28T17:11:40.517Z] Test passed after 2 failed attempts on upgrade/react-18-pure.
[2022-11-28T18:04:09.567Z] Test passed after 2 failed attempts on upgrade/react-18-pure.
[2022-11-30T09:23:29.149Z] Test passed after 2 failed attempts on upgrade/react-18-pure.
[2022-12-16T06:48:27.653Z] Test passed after 1 failed attempt on add/flaky-test.
[2022-12-16T08:05:39.902Z] Test passed after 2 failed attempts on trunk.
[2022-12-16T09:09:09.040Z] Test passed after 2 failed attempts on add/typography-support-to-latest-comments.
[2022-12-16T09:50:34.505Z] Test passed after 2 failed attempts on update/dedupe-scheduler-package.
[2022-12-16T09:56:49.150Z] Test passed after 1 failed attempt on add/use-select-static-tests.
[2022-12-16T10:07:53.228Z] Test passed after 1 failed attempt on trunk.
[2022-12-16T10:38:01.915Z] Test passed after 1 failed attempt on try/page-list-submenu.
[2022-12-16T11:34:18.354Z] Test passed after 2 failed attempts on update/use-select-sync-external-store.
[2022-12-16T11:42:52.501Z] Test passed after 2 failed attempts on remove/nux.
[2022-12-16T12:49:58.035Z] Test passed after 1 failed attempt on trunk.
[2022-12-16T12:52:04.988Z] Test passed after 2 failed attempts on try/integrate-openverse.
[2022-12-16T13:04:34.088Z] Test passed after 1 failed attempt on update/docgen-list-types.
[2022-12-16T13:18:27.820Z] Test passed after 1 failed attempt on trunk.
[2022-12-16T13:29:11.143Z] Test passed after 1 failed attempt on fix/pattern-setup-slides-heights.
[2022-12-16T14:35:05.011Z] Test passed after 1 failed attempt on try/iframe-block-based-theme-post-editor.
[2022-12-16T14:56:05.965Z] Test passed after 1 failed attempt on try/integrate-openverse.
[2022-12-16T15:56:47.468Z] Test passed after 1 failed attempt on update/docgen-list-types.
[2022-12-16T16:16:23.822Z] Test passed after 2 failed attempts on update/page-list-dedupe-code.
[2022-12-16T16:31:47.721Z] Test passed after 1 failed attempt on trunk.
[2022-12-16T16:39:27.842Z] Test passed after 1 failed attempt on try/child-theme-inherit-parent-style-variations.
[2022-12-16T17:26:38.539Z] Test passed after 1 failed attempt on fix/editor-block-styles.
[2022-12-16T17:29:08.595Z] Test passed after 1 failed attempt on update/use-select-sync-external-store.
[2022-12-16T18:23:33.962Z] Test passed after 1 failed attempt on try/child-theme-inherit-parent-style-variations.
[2022-12-16T20:05:52.477Z] Test passed after 1 failed attempt on fix/parity-with-cores-php-ci-jobs.
[2022-12-16T21:37:59.474Z] Test passed after 2 failed attempts on trunk.
[2022-12-18T07:58:05.130Z] Test passed after 2 failed attempts on add/rowspan-support-to-table.
[2022-12-18T08:43:56.718Z] Test passed after 1 failed attempt on cleanup/with-filters-tests.
[2022-12-19T00:22:39.467Z] Test passed after 1 failed attempt on try/rss-block-improvements.
[2022-12-19T02:05:53.816Z] Test passed after 1 failed attempt on try/style-engine-make-block-supports-extensible.
[2022-12-19T02:58:26.509Z] Test passed after 1 failed attempt on fix/verse-default-font-family-style.
[2022-12-19T04:23:28.822Z] Test passed after 1 failed attempt on try/rss-block-improvements.
[2022-12-19T04:27:21.908Z] Test passed after 2 failed attempts on try/style-engine-make-block-supports-extensible.
[2022-12-19T06:02:18.939Z] Test passed after 1 failed attempt on try/style-engine-make-block-supports-extensible.
[2022-12-19T07:11:21.236Z] Test passed after 1 failed attempt on update/typography-block-support-sync-with-6-1.
[2022-12-19T07:40:16.694Z] Test passed after 1 failed attempt on trunk.
[2022-12-19T08:58:40.145Z] Test passed after 1 failed attempt on try/rearchitect-webfonts-api.
[2022-12-19T10:24:11.310Z] Test passed after 2 failed attempts on refactor/post-editor-perf-test.
[2022-12-19T12:39:31.271Z] Test passed after 1 failed attempt on cleanup/with-filters-tests.
[2022-12-19T13:14:00.108Z] Test passed after 1 failed attempt on try/test-46598.
[2022-12-19T13:38:17.442Z] Test passed after 1 failed attempt on cleanup/border-box-control-test.
[2022-12-19T14:30:10.366Z] Test passed after 1 failed attempt on improve/url-popover-tests-act.
[2022-12-19T15:34:04.877Z] Test passed after 1 failed attempt on remove/lodash-block-editor-reducer.
[2022-12-19T15:42:40.601Z] Test passed after 1 failed attempt on fix/suspense-tests-no-node-access.
[2022-12-19T16:42:42.093Z] Test passed after 1 failed attempt on try/test-46598.
[2022-12-19T17:33:51.739Z] Test passed after 1 failed attempt on try/query-loop-scope-variations-connected-to-inserter-variations.
[2022-12-19T19:23:31.065Z] Test passed after 2 failed attempts on fix/tag-processor-back-too-far.
[2022-12-19T20:26:52.003Z] Test passed after 1 failed attempt on fix/navigation-link-block-test-prefix.
[2022-12-19T21:00:08.176Z] Test passed after 2 failed attempts on add/template-types-to-the-patterns-api.
[2022-12-19T21:00:58.328Z] Test passed after 1 failed attempt on fix/tag-processor-back-too-far.
[2022-12-19T23:22:54.797Z] Test passed after 2 failed attempts on try/making-custom-css-experimental.
[2022-12-20T00:27:10.581Z] Test passed after 1 failed attempt on revert-46487-add/guard-against-undefined-raw-content-in-widget-to-block.
[2022-12-20T00:31:12.681Z] Test passed after 2 failed attempts on try/making-custom-css-experimental.
[2022-12-20T01:23:01.830Z] Test passed after 1 failed attempt on update/docgen-list-types.
[2022-12-20T01:40:47.959Z] Test passed after 1 failed attempt on fix/tag-processor-back-too-far.
[2022-12-20T02:01:49.339Z] Test passed after 2 failed attempts on fix/tag-processor-back-too-far.
[2022-12-20T03:15:59.021Z] Test passed after 1 failed attempt on fix/tag-processor-back-too-far.
[2022-12-20T04:09:18.875Z] Test passed after 2 failed attempts on fix/performance-tests.
[2022-12-20T05:16:48.660Z] Test passed after 1 failed attempt on add/block-style-editing.
[2022-12-20T05:35:07.182Z] Test passed after 1 failed attempt on revert-46487-add/guard-against-undefined-raw-content-in-widget-to-block.
[2022-12-20T06:09:14.890Z] Test passed after 1 failed attempt on fix/demo-e2e-cors.
[2022-12-20T06:27:23.135Z] Test passed after 1 failed attempt on try/user-global-styles-revisions.
[2022-12-20T08:35:23.797Z] Test passed after 1 failed attempt on optimize/block-appender-rerender.
[2022-12-20T10:02:09.810Z] Test passed after 1 failed attempt on try/integrate-openverse.
[2022-12-20T10:35:34.954Z] Test passed after 2 failed attempts on remove/omit-rn-test-mocks.
[2022-12-20T10:38:35.678Z] Test passed after 1 failed attempt on remove/lodash-block-editor-reducer.
[2022-12-20T10:46:20.494Z] Test passed after 1 failed attempt on add/query-loop-terms-dynamic-suggestions-fetching.
[2022-12-20T10:47:42.900Z] Test passed after 1 failed attempt on refactor/panel-body-tests.
[2022-12-20T10:59:26.128Z] Test passed after 1 failed attempt on optimize/block-appender-rerender.
[2022-12-20T11:03:28.400Z] Test passed after 1 failed attempt on fix/source-link-params.
[2022-12-20T11:16:15.684Z] Test passed after 1 failed attempt on fix/tag-processor-back-too-far.
[2022-12-20T11:23:13.004Z] Test passed after 1 failed attempt on form-fields.
[2022-12-20T11:25:52.375Z] Test passed after 1 failed attempt on trunk.
[2022-12-20T11:37:50.556Z] Test passed after 1 failed attempt on add/get-attributes-by-prefix-method.
[2023-11-07T22:52:07.341Z] Test passed after 1 failed attempt on experiment/show-styles-inherited-values.
[2024-01-12T13:49:20.864Z] Test passed after 1 failed attempt on update/table-cell-alignment.
[2024-03-07T20:10:44.113Z] Test passed after 1 failed attempt on experiment/show-styles-inherited-values.
Error: expect(received).toBe(expected) // Object.is equality

Expected: "Bold"
Received: "Undo"
    at ToolbarRovingTabindexUtils.expectLabelToHaveFocus (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/toolbar-roving-tabindex.spec.js:188:23)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/various/toolbar-roving-tabindex.spec.js:145:3
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Nov 7, 2022
github-actions bot referenced this issue Dec 16, 2022
* Post a summary of the flaky tests to the commit

* Add test for rendering commit comment

* Update name from admin to puppeteer
github-actions bot referenced this issue Dec 16, 2022
* adds page list as child of submenu and disables direct insert

* fix page link CSS when adding to submenu, enable transform to pagelist, restore direct insert

* try to not render a wrapper if page list block is nested

* Fixes styling, aligns off canvas implementation to list view, fixes
styling bug of page list

Co-authored-by: Dave Smith <444434+getdave@users.noreply.github.com>
Co-authored-by: Maggie <3593343+MaggieCabrera@users.noreply.github.com>
Co-authored-by: Ben Dwyer <275961+scruffian@users.noreply.github.com>

* fix fixture

* add missing useEffect

* Fixes markup rendering in the editor to avoid a double LI element

Co-authored-by: Ben Dwyer <275961+scruffian@users.noreply.github.com>
Co-authored-by: Maggie <3593343+MaggieCabrera@users.noreply.github.com>

* added submenu container class to the page list item uls

* Ensure submenus are correctly positioned in the editor

* add a comment

Co-authored-by: Andrei Draganescu <github@andreidraganescu.info>
Co-authored-by: Dave Smith <444434+getdave@users.noreply.github.com>
Co-authored-by: Maggie <3593343+MaggieCabrera@users.noreply.github.com>
Co-authored-by: Ben Dwyer <275961+scruffian@users.noreply.github.com>
Co-authored-by: Ben Dwyer <ben@escruffian.com>
Co-authored-by: MaggieCabrera <maggie.cabrera@automattic.com>
github-actions bot referenced this issue Dec 16, 2022
* used smaller lock icon on off canvas editor

* reduce size of lock icon on list view too

* removed repeated css
@t-hamano t-hamano self-assigned this Dec 18, 2022
@t-hamano
Copy link
Contributor

I have migrated the E2E test to Playwright at #46634.
If no test failures occur after this PR is merged, I would like to close this issue.

@t-hamano
Copy link
Contributor

This issue will be closed after confirming that the instability has been improved by #46634.

@t-hamano t-hamano reopened this Dec 20, 2022
@t-hamano
Copy link
Contributor

Since this #46634 was merged, GitHub Actions have run the e2e test over 10 times on trunk and the Playwright test have never failed.
I consider this issue resolved and will close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants