Migrate Toolbar roving tabindex tests to Playwright #46634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
t-hamano
commented
Dec 18, 2022
Comment on lines
+189
to
+198
| let ariaLabel = await this.page.evaluate( () => | ||
| document.activeElement.getAttribute( 'aria-label' ) | ||
| ); | ||
| // If the labels don't match, try pressing Up Arrow to focus the block wrapper in non-content editable block. | ||
| if ( ariaLabel !== label ) { | ||
| await this.page.keyboard.press( 'ArrowUp' ); | ||
| ariaLabel = await this.page.evaluate( () => | ||
| document.activeElement.getAttribute( 'aria-label' ) | ||
| ); | ||
| } |
There was a problem hiding this comment.
I couldn't update this section to an accessible implementation. This implementation also exists in the testing of image block.
This was referenced Dec 18, 2022
|
Four playwright tests were run, all of which passed. |
skorasaurus
added
the
[Type] Automated Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #38851.
Migrate
toolbar-roving-tabindex.test.jsto its Playwright version.Why?
Part of #38851.
How?
See MIGRATION.md for migration steps.
All test cases were migrated as is, except for the rewrite to the role selector and the utility class.
Testing Instructions
Run
npm run test:e2e:playwright test/e2e/specs/editor/various/toolbar-roving-tabindex.test.jsAbout flaky test
In #45588, the following tests are reported as flaky:
can reach toolbar items with arrow keys after pressing alt+F10In this test, the focus is expected to be on the button with the "Bold" label.
3d6979e2428f7caf5f21b8aa17a610ff.mp4
However, somehow the focus is on the button with the "Align" label, and the test fails.
I have done nothing special but would like to close #45588 if it is confirmed that the instability has been resolved by migration.