Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page List allows insertion of any child block #46224

Closed
getdave opened this issue Dec 1, 2022 · 1 comment · Fixed by #46269
Closed

Page List allows insertion of any child block #46224

getdave opened this issue Dec 1, 2022 · 1 comment · Fixed by #46269
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Dec 1, 2022

Whilst testing the auto inserted Page List in the Nav block we noticed it's possible to insert any block type within the Page List block itself.

Screen.Capture.on.2022-12-01.at.10-55-54.mp4

Page List should only allow core/page-list-item.

@getdave getdave added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block labels Dec 1, 2022
@scruffian
Copy link
Contributor

There are a few different ways that users can add blocks to the Page List block:

  1. I can add page list as a child of page list using the appender
  2. I can drag and drop some blocks into the block.

We need to make sure these things are also not possible.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 2, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Block] Page List Affects the Page List Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants