Page List: Prevent users from adding inner blocks to Page List #46269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +28 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
getdave
approved these changes
Dec 2, 2022
mpkelly
pushed a commit
to mpkelly/gutenberg
that referenced
this pull request
Dec 7, 2022
…ress#46269) * Page List: Allow only the page-list-item block, and disable the inserter and drag and drop * Also lock the page list item blocks
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This prevents users from modifying the content of the Page List block.
Fixes #46224.
Why?
Page List is a controlled block - it shouldn't allow users to add blocks to it in any way.
How?
We apply locking to the innerblocks, disabled the appender and turn off drag and drop.
Testing Instructions
Add a Page List block
Try to find a way of modifying the content of the block
Testing Instructions for Keyboard
As above
Co-authored-by: Maggie 3593343+MaggieCabrera@users.noreply.github.com
Co-authored-by: Dave Smith 444434+getdave@users.noreply.github.com