Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Gutenberg respect the rich_editing user option? #4634

Closed
danielbachhuber opened this issue Jan 22, 2018 · 7 comments
Closed

Should Gutenberg respect the rich_editing user option? #4634

danielbachhuber opened this issue Jan 22, 2018 · 7 comments
Assignees
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@danielbachhuber
Copy link
Member

In the classic editor, a WordPress user can disable the rich_editing option. If this is disabled, then TinyMCE isn't loaded when editing a post.

Should Gutenberg also respect the rich_editing user option, or does this feature become deprecated?

From https://wordpress.slack.com/archives/C02QB2JS7/p1516553718000137

@danielbachhuber danielbachhuber added Backwards Compatibility Issues or PRs that impact backwards compatability [Type] Question Questions about the design or development of the editor. labels Jan 22, 2018
@bobbingwide
Copy link
Contributor

This was something I was testing earlier this week. I'd noted problems when content created in the text editor got imported into the visual editor. Basically my shortcode inside comments disappeared. Looks like it's an existing bug which Gutenberg exacerbates

@bobbingwide
Copy link
Contributor

bobbingwide commented Jan 25, 2018

An update on yesterdays comment. The shortcode inside comments problem could have been user error with HTML comments not being ended properly. e.g. Double hyphens converted to ndash or mdash on input. I've noted this happening when creating content using an iPad.

I have determined that using the Classic editor on a post marked as Gutenberg can produce problems toggling between Visual and Text. This was raised as #4672.

@bobbingwide
Copy link
Contributor

Having pondered over this question for a couple of days... since I believe I was the one who prompted it. I have decided that there are a number of requirements in this area.

  1. Whether or not you want Rich editing (aka WYSIWYG) for the Classic editor
  2. Whether or not you want Visual editing for the Block editor
  3. user option to select the default editor and mode for new posts
  4. Edit links should take into account current choice
  5. Ability to prevent switching editor mode on selected content.

The Classic Editor is still required

  • for post types that do not support the REST API
  • for meta boxes that are not compatible with the block editor
  • The text editor is required when hand crafted content can be broken by the rich editor.
  • Therefore the option to prevent rich_editing should still exist.

Restricting the Block editor to Code editing

It is also true that the Block editor can break posts.
I have determined that in order to create shortcodes where my new lines are respected I have to use either the Code editor mode or stick with the Classic editor.

In the future I envisage meta blocks which only exist for the Block editor and posts which can only be edited safely in the Code editor.

user should have the option to choose the default editor

Given that the Classic editor is still required the user should not be forced into using the Block editor for new or existing content. The system should respect the user's choices.
i.e. The user should be able to choose the default mode for creating new posts.

edit links should take into account current choice

When a user is editing and viewing content using the Classic editor then any edit link associated with the content should take the user to the same editor as previously loaded.

Ability to prevent switching editor

The user should be able to lock content to a particular editor mode.
This is to avoid content being broken by the switch to another mode.

For WordPress.com

I understand these requirements may be incompatible with the needs of WordPress.com.
Any new code should take this into account.

Conclusion

In response to the original question. Yes. The rich_editing option is still required.
And some people will benefit from this being extended to take into account another editor and its modes.

@aduth
Copy link
Member

aduth commented Mar 20, 2018

Related: #5670

@danielbachhuber danielbachhuber added this to the Merge Proposal milestone Mar 29, 2018
@karmatosed karmatosed modified the milestones: Merge Proposal, Merge Proposal: Back Compat Apr 12, 2018
@mattyrob
Copy link

I came across this ticket while trying to answer the very question it poses.

For as long as I've used WordPress (over 10 years) the TinyMCE editor has had a backup option directly in the core of a simple text editor.

When TinyMCE is replaced by Gutenberg, I cannot imagine why leaving the backup would not be a wise decision, it allows any level of WordPress user to drop back to a simpler editor to fix issues in established content that may not be appropriate for the risk environment editor. It also gives and option to WordPress users who may not be ready to use Gutenberg but don't have capabilities to install and activate the Classic Editor plugin themselves.

@mtias mtias removed this from the Merge: Back Compat milestone Oct 3, 2018
@mtias mtias added the Needs Decision Needs a decision to be actionable or relevant label Oct 3, 2018
@aaronjorbin aaronjorbin added this to the Completed: UI / UX milestone Oct 8, 2018
@mtias
Copy link
Member

mtias commented Nov 1, 2018

I think we should respect the setting, it's the easiest path forward — otherwise removal of the setting should be considered and it's a bigger ordeal.

@mtias mtias added [Type] Task Issues or PRs that have been broken down into an individual action to take and removed Needs Decision Needs a decision to be actionable or relevant [Type] Question Questions about the design or development of the editor. labels Nov 1, 2018
@mattyrob
Copy link

mattyrob commented Nov 9, 2018

This is still 'broken' in WordPress 5.0 beta 3 (43883)

Are there plans to patch this before RC or full release?

@mkaz mkaz self-assigned this Nov 16, 2018
@mkaz mkaz added the [Status] In Progress Tracking issues with work in progress label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

No branches or pull requests

8 participants