Honor the Disable Visual Editor setting #12000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Honors the user setting for `Disable the visual editor when writing` If the user checks the option to disable visual editor: - Returns from Gutenberg init - Removes the links to Classic Editor in post list - Removes the Gutenberg menu item When editing a post, it will load the plain text editor.
Moves the user_can_richedit to attach just on the filters and not spread through out different fucntions. add_filter( 'gutenberg_can_edit_post_type', 'user_can_richedit', 5 ); add_filter( 'gutenberg_can_edit_post', 'user_can_richedit', 5 ); add_filter( 'use_block_editor_for_post', 'user_can_richedit', 5 );
* Don't include core function use_block_editor_for_post * Don't show Gutenberg menu in admin sidebar, since Demo link will not load block editor, still plain text editor
mtias
added
the
Backwards Compatibility
gziolo
added
the
[Priority] High
|
@gziolo @youknowriad Is there a core Trac ticket for this? |
|
@danielbachhuber Not that I'm aware of? Is the process to create a trac ticket for each php change? Or do we do git diffs since last updates or something? Just trying to understand the process here? |
Yes. |
youknowriad
reviewed
Nov 19, 2018
| @@ -67,6 +67,9 @@ function the_gutenberg_project() { | |||
| * @since 0.1.0 | |||
| */ | |||
| function gutenberg_menu() { | |||
| if ( ! gutenberg_can_edit_post( $post ) ) { | |||
| return; | |||
| } | |||
There was a problem hiding this comment.
This check is creating a warning and for me it doesn't make sense to check this here at all. It's being addressed in #12053
|
Trac ticket https://core.trac.wordpress.org/ticket/45375 |
|
Thanks @youknowriad for shepherding the issue through. Plus creating the trac ticket, I had a mental note to ask about the process for keeping plugin/core in sync. |
noisysocks
added a commit
that referenced
this pull request
Nov 21, 2018
This reverts commit 095d18f.
youknowriad
pushed a commit
that referenced
this pull request
Nov 21, 2018
This was referenced Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4634.
Show the plain text editor if the user checks the "Disable the visual editor when writing" option
See #4634
How has this been tested?
From user settings, check option to Disable the visual editor:
Types of changes
Checklist: