Revert "Honor the Disable Visual Editor setting (#12000)" #12151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 095d18f.
noisysocks
added
[Type] Bug
gziolo
approved these changes
Nov 21, 2018
|
Seems like it will fix the reported issue. However, we still need to find a way to fix the original issue which we are about to revert. |
|
I pushed a commit adding the RichText support in Gutenberg itself. |
|
Code in 97ffd1b looks good, I'm testing it. |
youknowriad
deleted the
revert/honor-the-disable-visual-editor-setting
branch
ocean90
reviewed
Nov 21, 2018
| </div> | ||
| { isRichEditingEnabled && ( | ||
| <div className="edit-post-text-editor__toolbar"> | ||
| <h2>{ __( 'Editing Code' ) }</h2> |
There was a problem hiding this comment.
@youknowriad Should this headline maybe still be displayed (without the button)? See #12182 for a related report.
There was a problem hiding this comment.
Sure no strong opinion.
This was referenced Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12148 by reverting #12000.
From #12148 (comment):