Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve accessible text of Open Navigation List View button #47007

Closed
getdave opened this issue Jan 10, 2023 · 6 comments · Fixed by #47032
Closed

Improve accessible text of Open Navigation List View button #47007

getdave opened this issue Jan 10, 2023 · 6 comments · Fixed by #47032
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Experimental Experimental feature or API.

Comments

@getdave
Copy link
Contributor

getdave commented Jan 10, 2023

As reported in #46939 (comment), currently the text of the button in block toolbar which opens the Offcanvas List View for the Nav block is not descriptive enough.

Consider a more descriptive name for the feature and utilise this on the button.

cc @WordPress/gutenberg-design for input here.

@getdave getdave added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Block] Navigation Affects the Navigation Block [Type] Experimental Experimental feature or API. labels Jan 10, 2023
@jameskoster
Copy link
Contributor

I believe this is the button referenced:

Screenshot 2023-01-10 at 12 37 00

@jameskoster jameskoster added the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Jan 10, 2023
@draganescu
Copy link
Contributor

I think we should remove this button. I think it's a superfluous addition for quite a while, provides no extra value, and it is confusing.

@getdave
Copy link
Contributor Author

getdave commented Jan 10, 2023

provides no extra value, and it is confusing.

Are you able to elaborate on this a little? 🙏

@draganescu
Copy link
Contributor

@getdave

  • The button is unique to the navigation block and the action opens the settings sidebar. There is a button to open settings.
  • The fact that editing nested content is part of a sidebar that is called settings, it somewhat related to @alexstine 's issue with chaotic context - but nevertheless there is an UX in place to get to settings.
  • So then, what is this button,
    • A sort of shortcut?
    • Do we need to toggle it on and off based on display state of the settings sidebar?
    • Do we need to toggle it off if the new tabs of the inspector are set to something other than list view?
    • We can't even open the list view directly yet.

For all these reasons it is not a good button :) it's a bad button.

@getdave
Copy link
Contributor Author

getdave commented Jan 10, 2023

Excellent reasoning. Now we have the appropriate context available I think we should raise a PR to remove the button. Much appreciated 🙇

@provenself
Copy link

Looks like this is settled — okay to remove the Needs Copy Review tag?

@jameskoster jameskoster removed the Needs Copy Review Needs review of user-facing copy (language, phrasing) label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Experimental Experimental feature or API.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants