Remove the list view button from the navigation block #47032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: -372 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 3bc58e0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/3884746824
|
|
The reasoning seems solid to me, and I think we can lose the button. At this point it does feel superfluous. However this change will create a "who moved my cheese?" moment for existing users (and probably require documentation updates). Are there any plans to guide users around once off-canvas navigation graduates from experiment status? |
|
The button was only added in December, in 14.8 correct? I think the potential negative user impact would be low because of the short time? |
|
In that case ignore me, I thought it had been there much longer. |
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #47007, #47008, #47009
The "Test a new "off canvas" editor for navigation block using the block inspector and a tree view of the current menu" experiment introduces a button in the navigation block's toolbar to open the settings sidebar.
The goal of the button is to serve as a way for users to discover there is a tree view of their menu in the settings sidebar.
This PR removes it.
Why?
Previously the button had another incarnation which was transformed in #46335 to the current state.
The current state has some issues:
How?
It undoes the elements introduced in #46335
Testing Instructions
Testing Instructions for Keyboard
N/A
Screenshots or screencast
N/A