Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-canvas theme color no longer same as admin color #47347

Closed
jasmussen opened this issue Jan 23, 2023 · 5 comments · Fixed by #47416
Closed

In-canvas theme color no longer same as admin color #47347

jasmussen opened this issue Jan 23, 2023 · 5 comments · Fixed by #47416
Assignees
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jasmussen
Copy link
Contributor

When you choose an admin color scheme other than the default, the new color bleeds into controls in the canvas, including:

  • Primary buttons
  • Focus styles
  • Overlay styles

This recently regressed, and the default color is currently shown:

Screenshot 2023-01-23 at 10 22 55

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Jan 23, 2023
@jasmussen
Copy link
Contributor Author

CC: @youknowriad @ellatrix in case you have insights.

@youknowriad
Copy link
Contributor

I think components squad have been working on theming recently, so maybe this is related. cc @ciampo @mirka

@youknowriad
Copy link
Contributor

One other potential suspect is the recent move to iframe for block themes.

@youknowriad
Copy link
Contributor

Actually, since this only affects the canvas, it's probably the latter. cc @ellatrix

@t-hamano
Copy link
Contributor

t-hamano commented Jan 23, 2023

Perhaps we should move this mixin from style.scss to content.scss ?

@include wordpress-admin-schemes();

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 25, 2023
@ndiego ndiego moved this to 🏗️ In Progress in WordPress 6.2 Editor Tasks Jan 25, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.2 Editor Tasks Jan 31, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants