Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor: Navigation block items window modal goes out of screen when both the List View & Block Inspector sidebar are active or inactive #48059

Closed
franzaurus opened this issue Feb 14, 2023 · 12 comments · Fixed by #48402
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended

Comments

@franzaurus
Copy link
Contributor

franzaurus commented Feb 14, 2023

Description

When trying to add menu items under the navigation block, the block items modal appears in half or completely goes out of screen when both the List View and the Blocks Inspector are toggled ON/OFF.

First reported on trac https://core.trac.wordpress.org/ticket/57694

It seems this is a core-specific issue, the problem does not affect the Gutenberg 15.1 plugin.

Step-by-step reproduction instructions

  1. Activate TT3 or other block theme
  2. Go to its header
  3. Edit the Navigation block via the Editor
  4. Toggle both the List View and the Block Inspector ON/OFF
  5. Add menu items
  6. Notice the blocks window modal appears in half or even goes out of the screen.

Screenshots, screen recording, code snippet

navigation-added-items

Environment info

WP 6.2 beta 1, Firefox 109.0.1, Windows 11, TT3 & Powder themes.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added the [Type] Bug An existing feature does not function as intended label Feb 14, 2023
@tomdevisser
Copy link
Member

Screenshot 2023-02-14 at 5 54 21 PM

I can't reproduce this issue in Gutenberg, probably because of the updates in the Navigation Block that seem to have replaced the Add Block pop-up with a new Add Link design. Does that mean this issue belongs to the WordPress/wordpress-develop repo?

@annezazu annezazu added the [Block] Navigation Affects the Navigation Block label Feb 16, 2023
@annezazu
Copy link
Contributor

@getdave & @scruffian tagging for you all!

@scruffian
Copy link
Contributor

I think this is fixed by #48195

@getdave
Copy link
Contributor

getdave commented Feb 21, 2023

I can't replicate this on TT3 on WP 6.2 Beta 2.

@franzaurus Are you still able to replicate this? Are there any more specific conditions that trigger it. I tried everything I could think of 🙏

@franzaurus
Copy link
Contributor Author

@getdave Unfortunately I'm still able to reproduce the issue on 6.2 Beta 2. I found that clicking the Navigation block or Social icons after adding items will trigger the popover cut off.

Adding navigation links item

nav-add-links-beta2

Adding social icons item

nav-social-links-beta2

@annezazu
Copy link
Contributor

Similar to #48148, I wonder if there's something again related to pop overs here: #48140 and #47923.

@t-hamano
Copy link
Contributor

I have tested again with WordPress Beta 3.

WordPress 6.2-beta3-55401 without Gutenberg enabled (Reproduced)

2298ba3cd2a1fcfce6e9a3e12ab2900f.mp4

WordPress 6.2-beta3-55401 with Gutenberg enabled (Not reproduced)

1eb532fcf47882b9a57211364cfcd450.mp4

@ntsekouras
Copy link
Contributor

Related: #48398

@ntsekouras
Copy link
Contributor

This seems to be a similar issue with dependencies resolution in core, as we had with valtio.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 24, 2023
@carolinan
Copy link
Contributor

carolinan commented Feb 24, 2023

I am also able to reproduce this in 6.2-beta3-55409 without Gutenberg active.

@getdave
Copy link
Contributor

getdave commented Feb 24, 2023

@ntsekouras Can I clarify. Do you believe this is a dependency related issue rather than, say, a Issue relating specifically to the Navigation block (or its List Viww editing feature)?

@ntsekouras
Copy link
Contributor

@ntsekouras Can I clarify. Do you believe this is a dependency related issue rather than, say, a Issue relating specifically to the Navigation block (or its List Viww editing feature)?

Yes, it related to floating-ui version and therefore affects Popover in general. By pinning the version, this should be resolved for beta 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

10 participants