Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect popover placement [6.2] #48140

Closed
ndiego opened this issue Feb 16, 2023 · 4 comments
Closed

Incorrect popover placement [6.2] #48140

ndiego opened this issue Feb 16, 2023 · 4 comments
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@ndiego
Copy link
Member

ndiego commented Feb 16, 2023

Description

First reported in Trac: #57730

In 6.2 Beta 2 without Gutenberg active, the position of the block inserter popover is occasionally incorrect. See the gifs below. Note this might be related to #47923.

Step-by-step reproduction instructions

  1. Using 6.2 Beta 2, create a new post/page.
  2. Using the inserter in the Editor, add an image block. Notice that the popover is in the correct position.
  3. Again, using the inserter in the Editor, go to add another block. Notice that the popover is located too far below the inserter button. The results were even more dramatic in #57730.

Screenshots, screen recording, code snippet

WordPress 6.2 Beta 2 (Incorrect position)

popover-6-2

WordPress 6.2 Beta 2 + Gutenberg Trunk (No Issues)

popover-6-2-gutenberg

WordPress 6.1.1 (No Issues)

popover-6-1

Environment info

  • WordPress 6.2 Beta 2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@ndiego ndiego added [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release labels Feb 16, 2023
@ndiego ndiego changed the title Incorrect popover placement Incorrect popover placement [6.2] Feb 16, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Feb 16, 2023
@t-hamano
Copy link
Contributor

I was also able to reproduce it in WordPress 6.2 Beta2.

If you make any changes to the content, perhaps as shown below, the popover will be misaligned when you click on the root level inserter:

block-theme.mp4

Curiously, this problem is not reproduced in the classic theme:

classic-theme.mp4

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 20, 2023

I happen to open a new issue which I have now closed as a duplicate.
#48234
Here is the initial comment I made.

Using the Site Editor.
Open List View. Then explore various blocks such as Nav block. Add a new link. Notice the modal is partly outside the right edge of the browser.
Then add a new link in the Social Links block. Again notice the modal is even further outside the right edge of the browser.

Step-by-step reproduction instructions
Go to the Site Editor.
Open List View.
In the Nav block add a new link. Notice location of popup link modal.
Add a Social Links block and add a service.
Notice the location of the modal popup.
Screenshots, screen recording, code snippet
Here is a reply:
https://app.replay.io/recording/page-template-editor-bluewinddesign-wordpress--1c3580d8-3826-4de8-ad21-5bf233de809d

Environment info
WordPress 6.2 beta 2
WordPress Beta Tester plugin
Twenty Twenty Three

@ciampo
Copy link
Contributor

ciampo commented Feb 20, 2023

As reported in #47923, a fix might have been identified and merged (#48237)

The next release of the beta should hopefully solve this issue 🤞

@t-hamano
Copy link
Contributor

I have confirmed that this issue is not reproduced in WordPress 6.2-beta3-55401 without Gutenberg enabled. If no one else can reproduce this issue, let's close this issue and focus on #47923, which is discussed in more depth.

@github-project-automation github-project-automation bot moved this from ❓ Triage to ✅ Done in WordPress 6.2 Editor Tasks Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
Development

No branches or pull requests

5 participants