Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the handling of focus when editing entity data #49098

Closed
draganescu opened this issue Mar 15, 2023 · 0 comments · Fixed by #49236
Closed

Test the handling of focus when editing entity data #49098

draganescu opened this issue Mar 15, 2023 · 0 comments · Fixed by #49236
Assignees
Labels
[Feature] History History, undo, redo, revisions, autosave. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.

Comments

@draganescu
Copy link
Contributor

In #48979 a fix was merged to solve focus loss which occurred when undo or redo was used inside an editor who managed entity editing via useBlockSync. We need to add a test that tests for our desired behavior in terms of focus management.

Ideally focus should remain to where it was on actions such as undo and redo. However, #48979 has a temporary - I hope - solution which moves the focus to the parent when the undo changes controlled inner blocks. This should be fixed too, but for now the test should test this focus parent behavior.

@draganescu draganescu added [Type] Enhancement A suggestion for improvement. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Feature] History History, undo, redo, revisions, autosave. [a11y] Keyboard & Focus labels Mar 15, 2023
@draganescu draganescu self-assigned this Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] History History, undo, redo, revisions, autosave. [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants