Adds focus management test for entity undo #49236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draganescu
added
[Type] Enhancement
|
Size Change: +1.54 kB (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Mar 21, 2023
getdave
reviewed
Mar 21, 2023
… existing template part grouping
getdave
reviewed
Mar 24, 2023
|
Flaky tests detected in 7086ad7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4510824330
|
getdave
reviewed
Mar 27, 2023
getdave
reviewed
Mar 27, 2023
Co-authored-by: Dave Smith <444434+getdave@users.noreply.github.com> Co-authored-by: Kai Hao <7753001+kevin940726@users.noreply.github.com>
|
@getdave this is ready again |
getdave
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
I see a few review comments marked as "Resolved" but no code changes. I just wanted to check whether that was intentional.
The points are relatively minor code quality things but it would be nice to tidy them up and keep with best practices.
Otherwise this is good to go 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #49098
In #48979 a fix for focus loss was merged. This adds a test for that fix.
Why?
To guard from regressions, but also to see the problem expressed in code.
How?
Adding a test.
Testing Instructions
Run:
The test should pass.
Revert the change in #48979 (the else branch here.
The test should fail.