Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit the trailing inserter #4951

Closed
jasmussen opened this issue Feb 8, 2018 · 6 comments · Fixed by #4953
Closed

Revisit the trailing inserter #4951

jasmussen opened this issue Feb 8, 2018 · 6 comments · Fixed by #4953
Assignees
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...

Comments

@jasmussen
Copy link
Contributor

As of the time of this writing, master features a new interface for inserting content in the context of the canvas. It has a side-inserter, no sibling inserter and a trailing inserter consisting only of a plain textfield. This is part of a cage match to simplify in-canvas insertion (#4669).

Having used this interface since it was merged in after the 2.1 release, we've had time to test it, even if it hasn't yet been released in the plugin. Already, feedback (including on the merge PR, #4539) has made it clear that aspects of the old interface are missing in the new, and aspects of the new weren't working as intended. This effectively closes #4669. As such, let's revert the side inserter, restore the sibling inserter, and revisit the trailing inserter.

Here is a mockup for an evolution of the trailing inserter:

trailing-inserter-v2

This is essentially a text input field giving you the usual access to either keep writing, or to use the Slash command. It restores recently used blocks on the right, but with Image and the inserter permanently added on the right. When you move the mouse towards these, or tab into them, the contrast increases.

This is inspired by the Dropbox Paper interface:

paper

As a reminder, here's what's in the 2.1 version of the plugin:

2 1

☝️ this is mostly what the trailing inserter has looked like since June 2017, where it looked like this.

CC: @karmatosed @mtias @aduth @youknowriad

@mtias mtias added [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Feb 8, 2018
@youknowriad youknowriad self-assigned this Feb 8, 2018
@jasmussen
Copy link
Contributor Author

More discussion around the trailing inserter, from way back when: #1553 (comment)

@mtias
Copy link
Member

mtias commented Feb 8, 2018

This seems like a good evolution to me as it balances the benefits of quick access to blocks and the ability to just click and continue writing.

@karmatosed
Copy link
Member

This feels like a solid evolution of the interface. It's good to see where the roots come from and where we are now at. I like the idea of bringing back the recent blocks once someone has some, yet combining them with the most common options.

@mtias
Copy link
Member

mtias commented Feb 8, 2018

Side note, but this also scales much better with nesting and columns, as we don't need a "bottom" area for it.

@carlhancock
Copy link

I dig it! Nice work @jasmussen!

@folletto
Copy link
Contributor

As a sidenote, I think this is one of the scenarios where "icon only" works, as it's an advanced/shortcut feature — while the "+" for universal insertion with labels is also reinforced.

Good interation 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion...
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants