Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Editor: Remove block inserter shortcuts #19045

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

aduth
Copy link
Member

@aduth aduth commented Dec 10, 2019

Related: #10519, #4951
Partially addresses #5055

This pull request seeks to remove the block inserter "shortcuts" which would previously appear when hovering the "appender" area below the list of blocks in the block editor.

Needs Design/Accessibility Feedback: It is proposed that they be removed due to:

Their removal yields a simplification, both in the technical implementation and to the benefit of users in reducing the surface area of block insertion options.

Before After
Before After

Testing Instructions:

Verify there are no regressions in the insertion of blocks, specifically in using the "default" appender, which is expected to show either when:

  1. The post is empty
  2. The last block is a selected, empty paragraph
  3. The last block is a non-paragraph

(It's acknowledged that the above logic flow is still prone to confusion, which could be addressed in subsequent improvements surrounding #10519)

The "+" button should still be shown where the "shortcuts" would have previously been expected to appear, to the left of the block list.

@aduth aduth added [Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Design Feedback Needs general design feedback. Needs Accessibility Feedback Need input from accessibility [Package] Block editor /packages/block-editor labels Dec 10, 2019
@youknowriad
Copy link
Contributor

I've considered this as well for some time now. I agree that they don't bring much value. Any perspective here @ZebulanStanphill @jasmussen @mapk

@jasmussen
Copy link
Contributor

Remove them! I've not used them once.

@chrisvanpatten
Copy link
Contributor

Goodbye inserter shortcuts, you will not be missed 👋

@ellatrix
Copy link
Member

Yes please!

@ZebulanStanphill
Copy link
Member

ZebulanStanphill commented Dec 10, 2019

I never use the inserter shortcut buttons. The slash inserter is faster and more useful.

I'd go a step further and change the empty Paragraph inserter to look the same as it does for nested blocks, since having the icon to the left and outside of the block border is kind of confusing.

@karmatosed
Copy link
Member

+1 to remove :)

@aduth
Copy link
Member Author

aduth commented Dec 11, 2019

I'd go a step further and change the empty Paragraph inserter to look the same as it does for nested blocks, since having the icon to the left and outside of the block border is kind of confusing.

Do you think this would be fine for a follow-up pull request, or is the need for this directly impacted by the removal of the shortcuts? Given the likelihood that discussions surrounding #10519 can stagnate, I'm inclined to push for more incremental steps.

I sense what you're suggesting is similar to what was explored in #11329, which was closed in part due to lingering questions around (intentional?) differences between top-level and nested block inserters (#11329 (comment)).

@mapk
Copy link
Contributor

mapk commented Dec 11, 2019

I've also found they cause confusion for users who hover over them wondering what they are and if they're what they need.

I'm for removing them.

@mapk mapk removed the Needs Design Feedback Needs general design feedback. label Dec 11, 2019
@ZebulanStanphill
Copy link
Member

@aduth I'm fine with just removing the block inserter shortcuts for now. However, I do think that with them gone, there is little reason to have the inserter look different at the top level vs. nested contexts.

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it.

@shaunandrews
Copy link
Contributor

Do it!

@aduth aduth force-pushed the remove/block-appender-shortcuts branch from 9ff70d4 to 7f5ff74 Compare December 20, 2019 17:48
@aduth aduth merged commit 14401e0 into master Dec 20, 2019
@aduth aduth deleted the remove/block-appender-shortcuts branch December 20, 2019 18:14
@ellatrix ellatrix mentioned this pull request Jan 6, 2020
6 tasks
@youknowriad youknowriad added this to the Gutenberg 7.2 milestone Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface Needs Accessibility Feedback Need input from accessibility [Package] Block editor /packages/block-editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants