Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider control for re-assigning a core/page-link block's page #49735

Open
richtabor opened this issue Apr 11, 2023 · 4 comments
Open

Consider control for re-assigning a core/page-link block's page #49735

richtabor opened this issue Apr 11, 2023 · 4 comments
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

What problem does this address?

To change say an About page to your site's "Now" page, you need to first delete the About page link, select the parent Navigation block, then re-add via the Inserter (or the new list view within the Navigation block).

We can simplify this by having a chip/token of the selected page within the Block Inspector. When you select it, you should be able to search for, and add other pages.

What is your proposed solution?

Instead of a delete/add-again flow, you would be able to click the clip/token selector to swap the page. We already have this UI, which could be leveraged perhaps, as well as other page link designs floating around:

I was thinking it could be the first control in the Block Inspector:

CleanShot 2023-04-11 at 17 26 24

CleanShot 2023-04-11 at 17 31 07

@richtabor richtabor added [Feature] Blocks Overall functionality of blocks [Block] Navigation Affects the Navigation Block [Block] Navigation Link Affects the Navigation Link Block labels Apr 11, 2023
@richtabor
Copy link
Member Author

Related in part to #48072

@richtabor
Copy link
Member Author

Related #49091 (comment)

@getdave
Copy link
Contributor

getdave commented Apr 19, 2023

@richtabor This PR starts to do what you are asking for I think #46981.

If it does and you feel it's important then please do let me know.

@richtabor
Copy link
Member Author

@richtabor This PR starts to do what you are asking for I think #46981.

I think it's a nice-to-have, compared to the current experience, though a bit more similar to the edit/search/replace flow here, where you can choose a different page from a popover perhaps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Feature] Blocks Overall functionality of blocks [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants