[WIP] Add Link Control UI to the Nav item block sidebar #46981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
changed the title
|
Size Change: +54 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 554218f. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4165160225
|
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
|
This is a POC and I'll pick it up again once the feature is stablised. |
scruffian
force-pushed
the
add/link-control-to-nav-link-block-sidebar
branch
from
9fd8fde
to
554218f
Compare
|
There's more input in #48072 for how to proceed here. |
scruffian
force-pushed
the
add/link-control-to-nav-link-block-sidebar
branch
from
554218f
to
2fa51cc
Compare
|
Rather than using the whole control I think we should only use |
|
Going to close this one out until someone says we still need it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds the
<LinkControl>component to the inspector controls sidebar of the Nav Link block.Closes #46217
Why?
Currently (and this is especially problematic when utilising the new offcanvas experiment for the Nav block) it's difficult to edit the link settings once it's been created because you don't have access to the link creation UI.
By adding it to the sidebar we provide this powerful feature.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast