Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot unselect list block #502

Closed
aduth opened this issue Apr 24, 2017 · 5 comments
Closed

Cannot unselect list block #502

aduth opened this issue Apr 24, 2017 · 5 comments
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Apr 24, 2017

Steps to reproduce:

  1. Navigate to the Gutenberg standalone page
  2. Click within the list block (toward the bottom)
  3. Try to click elsewhere on the page (outside canvas or another block)

Expected result:

The list block is unselected.

Actual result:

The list block flickers as unselected for a moment before once again becoming selected.

Screencast:

list

@aduth aduth added the [Type] Bug An existing feature does not function as intended label Apr 24, 2017
@BE-Webdesign
Copy link
Contributor

Just opened this in #501 lol!

@aduth
Copy link
Member Author

aduth commented Apr 24, 2017

Funny timing on that 😄 Good to have the additional context with the TinyMCE error there. I wasn't seeing that in my console when I was testing.

@ellatrix ellatrix added this to the Prototype Parity milestone Apr 26, 2017
@BE-Webdesign
Copy link
Contributor

BE-Webdesign commented Apr 27, 2017

The TinyMCE error in the console, is unrelated, has to do with something else. Not sure how that error was consistently popping up, but no longer does. ¯_(ツ)_/¯ Hovering seems to be the kiss of death so potentially in the hover event there is a problem. Can look at this tomorrow.

@ellatrix
Copy link
Member

If you run into it again, The given range isn't in document. is usually caused by the focus not being set, and trying to set a Range.

@mtias mtias added the [Feature] Blocks Overall functionality of blocks label Apr 27, 2017
@BE-Webdesign
Copy link
Contributor

This issue seems fixed for now somehow. Another PR must have inadvertently solved this problem. That can be kinda scary though. Now that it is fixed there is another problem for the list block that I will patch up quickly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants