Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus and content issues with list block #567

Closed
nylen opened this issue Apr 28, 2017 · 3 comments
Closed

Focus and content issues with list block #567

nylen opened this issue Apr 28, 2017 · 3 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@nylen
Copy link
Member

nylen commented Apr 28, 2017

In master I'm seeing some pretty severe issues with the list block:

  • It only accepts the focus when clicking outside of the list items' text, not when clicking on a word
  • Whenever any other Redux action is fired (the block is re-rendered?), any edits are discarded. Simply moving the mouse over the block is enough to trigger this.

Here's a screen recording of me attempting to perform some basic actions with the list block:

gutenberg-list-bugginess

Others in chats have been unable to reproduce this issue, I'm not sure if that's because it's just really strange or because it's only happening on my computer. I'm using Chrome 57.0.2987.110 (64-bit) on Debian-based Linux.

In any case, it looks like there is some still-undiscovered major bugginess here. A few past issues/PRs look pretty closely related:

@nylen nylen added [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended labels Apr 28, 2017
@nylen nylen added this to the Prototype Parity milestone Apr 28, 2017
@mtias mtias removed this from the Prototype Parity milestone May 1, 2017
@BoardJames
Copy link

Some of these were to be addressed by the pull request
#396
Unfortunately mimo84 went on holidays before all the issues could be resolved and we didn't have a chance to do a proper hand-off. I'll be working on bringing that back up to speed with the current state of the repo today.

@afercia
Copy link
Contributor

afercia commented May 3, 2017

Also, when navigating through blocks using only the Tab key, the list block is a keyboard trap. I guess because the Tab key is supposed to be used for the list items indentation (nesting) so at each Tab key press (or Shift+Tab) nothing happens and it's impossible to navigate away from this block using only the keyboard.
This would be a serious accessibility blocker.

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label May 3, 2017
@nylen
Copy link
Member Author

nylen commented May 5, 2017

This appears to have been fixed by an unrelated PR. I'm not sure which one, but this is a bit worrying. If there was a PR that addressed this issue specifically then it should have been linked to this issue. Anyway I'll close this out. @afercia the Tab keyboard trap should be a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants