Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to "View Site" from the Site Editor sidebar #50405

Closed
Tracked by #50394
richtabor opened this issue May 5, 2023 · 7 comments · Fixed by #50420
Closed
Tracked by #50394

Add action to "View Site" from the Site Editor sidebar #50405

richtabor opened this issue May 5, 2023 · 7 comments · Fixed by #50420
Assignees
Labels
Needs Design Feedback Needs general design feedback.

Comments

@richtabor
Copy link
Member

richtabor commented May 5, 2023

It is not possible to view your site within the Site View of the Site Editor. You can only do so after navigating into the Canvas and selecting the "View" selector in the editor toolbar.

Let's explore adding a "View Site" action from the Site Hub perhaps, to enable people to quickly view their site in a new tab.

Proposal

CleanShot 2023-05-05 at 15 55 45

@richtabor richtabor added the Needs Design Needs design efforts. label May 5, 2023
@richtabor richtabor moved this to Needs design, or refresh in 6.3 Design May 5, 2023
@richtabor richtabor added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels May 5, 2023
@richtabor
Copy link
Member Author

I don't love the varying sizes between the externalLink and search icons here.

Perhaps we could use a smaller variant of the externalLink icon (if not edit the current to be a bit smaller).

A smaller icon would also work better in the context of the Title bar (#50378 (comment)), and the newer ViewLink component in the editor header:

CleanShot 2023-05-05 at 15 59 06

@glendaviesnz
Copy link
Contributor

glendaviesnz commented May 8, 2023

Woops, overlooked the Needs design feedback tab. Was a pretty quick task to put up a PR though, so nothing lost if we don't go ahead with this.

@jasmussen
Copy link
Contributor

I wonder if in the site view, the site title could work as a link? I'm mainly thinking ahead to other options sitting in the site hub. A "plus" to add content, for example, could potentially sit there. I would think in the near term we can probably do with a plus in the title area of a detail page, but I still have a feeling that eventually such a plus will be convenient there.

I would agree we need a harmonized external link icon. I think we can potentially update the main icon directly, I don't think we need two variants. The only thing to be careful of there, is searching the codebase for any instances where we are using it at half size, I think that is done in help-text in a few instances.

@glendaviesnz
Copy link
Contributor

I wonder if in the site view, the site title could work as a link

Sounds like a good idea to me, we can add the 'Visit site' tooltip to it as an extra prompt - let me know if you want me to just switch that PR to do that for now instead of the extra icon.

@jasmussen jasmussen moved this from Needs design, or refresh to Needs feedback in 6.3 Design May 8, 2023
@richtabor
Copy link
Member Author

I wonder if in the site view, the site title could work as a link?

Maybe so? Although it's unclear that clicking site icon in the hub will take you back to WP Admin, but clicking the site title will take you to the front-of-site.

@jasmussen
Copy link
Contributor

Mainly I would urge caution in adding items to the site hub, keep it as contextual as possible as long as possible. I might see a "plus" button there to add new content, such as posts or pages, and we probably don't want to end up with too many buttons. It's a tricky balance.

@glendaviesnz
Copy link
Contributor

Should I just close my PR for now while this is discussed further?

@jasmussen jasmussen moved this from Needs feedback to Needs dev in 6.3 Design May 19, 2023
@jameskoster jameskoster moved this from Needs dev to Done in 6.3 Design Jun 7, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants