Add <ViewLink> component #50260
Merged
Add <ViewLink> component #50260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +101 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jameskoster
approved these changes
May 2, 2023
There was a problem hiding this comment.
Works for me:
The labels on other elements ('Preview' / 'Saved') make for a somewhat jumbled appearance. It would be nice to eliminate those given we have the "Show button text labels" preference.
There's still some design work happening on the title outline that can change the final placement of this action later on.
Indeed, it's easy to imagine this button moving somewhere like:
|
I think we should try next consolidating the preview dropdown into the icon button with tooltip |
|
Just hopping in to say..I love the idea of the view link being inside the title bar! |
priethor
added
[Type] Enhancement
mcsf
approved these changes
May 3, 2023
| import { store as coreStore } from '@wordpress/core-data'; | ||
| import { useSelect } from '@wordpress/data'; | ||
|
|
||
| export default function PreviewLink() { |
There was a problem hiding this comment.
Suggested change
| export default function PreviewLink() { | |
| export default function ViewLink() { |
Displays a button with an external icon to open a new window with the published post type
37 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #50217 and #50218.
This displays a discrete button for opening any current published post type in a new window. It uses the post type view label as provided.
There's still some design work happening on the title outline that can change the final placement of this action later on.