Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an icon for the Move to Trash button in the post editor instead. #50294

Open
aurooba opened this issue May 3, 2023 · 1 comment
Open
Labels
[Feature] Document Settings Document settings experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@aurooba
Copy link
Member

aurooba commented May 3, 2023

What problem does this address?

This came out of the discussion on Twitter that was triggered by the recent PR that was merged to move the Switch to Draft button into the Posts settings area in the Post Editor (#50217). Now that #50219 is also merged, can we/should we explore turning the Move to Trash button into an icon instead?

What is your proposed solution?

a small switch to draft button and a trash icon underneath the author dropdown in the WordPress post settings

I was imagining something like the mockup above, although I'm sure it needs refinement. Although ideally it would be nice to have a variation of the trash icon with the lid slightly open to indicate that you'd be moving something to the trash.

Since there's a move to change many of the post actions in the right hand of the Editor toolbar to icons as well (#50260, #50218), it makes sense to evaluate other post actions and see if they are candidates for icons as their default appearance as well.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Feature] Document Settings Document settings experience labels May 4, 2023
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Sep 11, 2024
@afercia
Copy link
Contributor

afercia commented Sep 11, 2024

Thanks for your feedback and interesting suggestion.
From an accessibility perspective the editor should strive to rather reduce the amount of icons and use labels with visible text. Proliferation of icons in the editor is a hug problem.

Icons usage should be reduced to a limited set of very well recognizable icons. Whle I do agree the 'bin' icon is well recognizable, I'd also note that it is generally used for the concept of 'delete', as in permanently delete. Move to trash is a pretty different logical concept and action so I'm not sure the bin icon would ever be a good one for this specific case.

Also noting #65023 just restored the big red 'Move to trash' button that was previously hidden behind the Post Summary panel three dot menu:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Document Settings Document settings experience [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants