Show confirmation dialog when moving a post to the trash #50219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +16.6 kB (+1%) Total Size: 1.64 MB
ℹ️ View Unchanged
|
jasmussen
approved these changes
May 1, 2023
There was a problem hiding this comment.
Yep, it's actually a little weird we don't have one, since we do have one for unpublishing:
Per your comment here, I think we have an opportunity to move away from the red color given there's a confirmation, and given it's actually moving the item to trash, not deleting it forever and ever.
mtias
commented
May 1, 2023
| onCancel={ () => setShowConfirmDialog( false ) } | ||
| > | ||
| { __( | ||
| 'Are you sure you want to move this post to the trash?' |
There was a problem hiding this comment.
We should probably avoid the term "post" or contextualize with whatever post type is the current context.
There was a problem hiding this comment.
I agree. Current context would be best here.
There was a problem hiding this comment.
Should we consider this as a blocker? cc @jasmussen
There was a problem hiding this comment.
I agree current context would be best, but since we are currently shipping in trunk without the warning, it seems an improvement to add one as a first step, but we can just rephrase to this:
Are you sure you want to move this to the trash?
There was a problem hiding this comment.
I just checked, and "switch to draft" also uses the "post" term in the confirmation message. I think we can merge this as it is and contextualize both in follow-up PR.
mtias
force-pushed
the
add/confirm-dialog-for-trashing-post
branch
from
f9fc21e
to
5f99550
Compare
|
Followed up with a padding fix in #50283. |
|
I can't speak for Matías, but I know he's endlessly busy and travelling right now, and with a green check I think we can just rebase this one and help land it. |
|
@jasmussen, sounds good. I'll rebase and merge this in a bit. |
Mamaduka
force-pushed
the
add/confirm-dialog-for-trashing-post
branch
from
5f99550
to
d271ec2
Compare
Mamaduka
added
[Type] Enhancement
|
Flaky tests detected in 8360ac7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6409042477
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #50217 it became apparent that we show a confirmation step for switching a post back to a draft state but we don't show one for moving a post to the trash bin.
Fixes #19125.
Fixes #34436.