Polish confirm dialog padding. #50283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasmussen
added
[Type] Enhancement
|
Size Change: -4 B (0%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
jameskoster
reviewed
May 3, 2023
| @@ -135,7 +135,7 @@ | |||
|
|
|||
| &.hide-header { | |||
| margin-top: 0; | |||
| padding-top: $grid-unit-30; | |||
| padding-top: $grid-unit-50; | |||
There was a problem hiding this comment.
Should this be $grid-unit-40 to match right, bottom, left?
There was a problem hiding this comment.
Yeah I guess it should (fixed). Initially I intentionally made it a bit larger because it felt bottom heavy otherwise. But revisiting it today, you're right, and this works too:
jameskoster
approved these changes
May 4, 2023
jasmussen
force-pushed
the
try/confirm-polish
branch
from
a68dee1 to
573e998
Compare
I believe @mirka has been working on adding the 40px variant to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the confirm/no-header modal to have correct padding.
Before:
After:
Testing Instructions
Publish a post, then in the inspector choose "switch to draft" and observe a padding that is optically balanced around all elements.