Button: Add opt-in prop for next 40px default size #50254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +78 B (0%) Total Size: 1.38 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5d6cdd5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4926245319
|
ciampo
added
the
has dev note
|
For the dev note, see #46741 |
|
Warning: Type of PR label error To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46741
What?
Adds a
__next40pxDefaultSizeprop to opt into the new 40px default size for Button.We're not quite ready to feature this prop in the documentation yet (like README and default code snippets), so I'll update those later when appropriate.
Why?
We need a way for folks to gradually adopt the new sizing scheme in a controlled way.
Testing Instructions
npm run storybook:devand go to the Canvas view for the Button component.__next40pxDefaultSizeand check that the size changes as expected.CleanShot.2023-05-03.at.00.36.16.mp4