Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Library page in Hybrid Themes that support Template Parts has a broken homepage preview #51295

Closed
aurooba opened this issue Jun 7, 2023 · 2 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Templates API Related to API powering block template functionality in the Site Editor [Type] Bug An existing feature does not function as intended

Comments

@aurooba
Copy link
Member

aurooba commented Jun 7, 2023

Description

This is a similar issue to what we saw in the 6.2 beta, #48391, and it's reproducible again in 6.2.2 – I'm not sure if it came back in 6.2.1, but it was fixed and confirmed fixed when the initial 6.2 release happened. I just noticed it again.

Step-by-step reproduction instructions

  1. Activate a classic theme with theme.json and support for block template parts that includes at least one block template part. (happy to provide an example theme if needed)
  2. Go to Appearance > Template Parts
  3. Click on the back button for All Template Parts
  4. See the loading screen where the homepage should be – this page shouldn't exist for hybrid themes, from my understanding, it should go straight back to the dashboard.

Screenshots, screen recording, code snippet

Without Gutenberg

Screen.Recording.2023-06-07.at.6.56.00.AM.mov

With Gutenberg 15.9.1

Screen.Recording.2023-06-07.at.7.08.18.AM.mov

Environment info

  • WordPress 6.2.2
  • Tested with AND without Gutenberg 15.9.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@aurooba aurooba added [Feature] Templates API Related to API powering block template functionality in the Site Editor [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended labels Jun 7, 2023
@annezazu annezazu moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jun 7, 2023
@annezazu
Copy link
Contributor

annezazu commented Jun 7, 2023

@Mamaduka in case you might be able to dig in!

@t-hamano
Copy link
Contributor

t-hamano commented Jul 2, 2023

WordPress 6.3 and the latest Gutenberg behave differently: when you press the back button on the All Template Parts page, it takes you to the Library page, but the loading status is not displayed in the canvas area, but the registered pattern is displayed.

I would like to close this issue as I believe this problem is no longer reproduced.

However, I have submitted issue #52150 because I don't believe it is strictly intended that non-block themes that support block template parts be able to access the Library page.

@t-hamano t-hamano closed this as completed Jul 2, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.3.x Editor Tasks Jul 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Templates API Related to API powering block template functionality in the Site Editor [Type] Bug An existing feature does not function as intended
Projects
No open projects
Development

No branches or pull requests

3 participants