Tracking: Library & Pattern Management Issues

[aaronrobertshaw]

The following lists cover known bugs and issues for the current state of the Library and pattern management features. Ideally, we'll get as many of these done as possible before the 6.3 beta 1; however, some work is likely to flow into the beta period, as enabled by the Introducing the Library blessed ticket.

Note: When adding a PR to this tracking issue, make sure it has the Backport to WP Beta/RC label on it if it should be included in the WP beta, thanks

Todo

• Library: Improve the screenreader announcements for category navigation #52005
• Erratic padding in pattern previews #52421 - (Possible duplicate: 51937) - actually just displaying padding as specified by the theme - I think we might have to live with this

In Progress

• Patterns: empty unsynced patterns added in site editor do not appear in post editor inserter #52227 - PR
• Template Parts: Add further details to template part panel #52476

Completed

• Rename "Library" to just "Patterns" - PR - @aaronrobertshaw
• Where’s the template part table view gone? - PR - @aaronrobertshaw
• Library: synced pattern shows as "standard" and unsynced - PR - @aaronrobertshaw
• Library: Snackbar notices are not shown when deleting a pattern #52003 - PR - @kevin940726
• Patterns: when editing in the Site Editor, sidebar lists "Template" rather than "Pattern" - PR - @aaronrobertshaw~
• Patterns: Detail page doesn't reference sync state - PR - @aaronrobertshaw
• My Patterns vs. Custom Patterns - PR @SaxonF
• Library: Set custom patterns as the initial state - PR @SaxonF
• Normalize template parts and pattern icons in "new" dropdown - PR - @jameskoster
• Inconsistent pattern creation modals - PR @SaxonF
• Custom Patterns not displayed in Pattern Modal - PR
• Switching from editing page to pattern causes incorrect editing template notification - Was already fixed in 51880
• Library: In the mosaic of entries template parts do not display the correct icon - PR - @carolinan
• Pattern focus mode DocumentActions should use the pattern icon #51992.
• Restore sidebar in focus mode on Pattern click through in Browse Mode Library  #51897
• Make library's default category fallback to header template parts if user has no custom patterns
• Command Palette: Nothing appears in the side menu after removing the template part #52023 - PR - @t-hamano
• Fix history back after entering edit mode from Patterns #52112~ - @kevin940726
• Block Editor: Unify texts for Create pattern modal #52151
• Library: Incorrect snackbar text and sidebar menu when removing template/template part #51969
• The Library page in Hybrid Themes that support Template Parts has a broken homepage preview #51295
• [Library] Add lock icon for theme patterns #51990 - @kevin940726
• Parts assigned to their own area do not appear in the site editor library. #52101 - PR - @aaronrobertshaw
• In 16.1 synced patterns added in the library have incorrect sync status set - @glendaviesnz
• Patterns: Remove ability for user to toggle sync status after pattern creation in 16.1 release #52230
• Fix site editor animation when moving from "edit" to "view" mode - PR - (status: looking for volunteers to take this over)
• Patterns list and grid: incorrect headings hierarchy and wrong usage of ARIA attributes #52253
• Patterns: Update section heading levels #52273 - @aaronrobertshaw
• Fix incorrect aria-describedby attributes for theme patterns #52263 - @kevin940726
• Update pattern library copy #52340
• Patterns: distinguish between theme patterns and template parts in category list #52382
• Patterns: Add hint to show template part move #52395
• Patterns: Display all custom template part areas in sidebar nav #52355
• "Manage Patterns" to open the Library > Custom patterns - PR - @aaronrobertshaw
• Custom Patterns: Allow renaming and duplication within the Site Editor (particularly renaming for 6.3) - PR - @aaronrobertshaw
• https://core.trac.wordpress.org/ticket/58716
• Library: Add some context about the currently selected category to the main 'Library Content' region #52006
• Library: revisit keyboard navigation for pattern items #52009
• Site Editor > Patterns > Template Part List: missing "add new template part" button #52435
• Reusable block/Pattern: option to create does not appear when editing content in site editor #51310
• Add client side pagination to improve performance of list page
• Add pagination to the 'My Patterns' view & switch sync status to toggle group filter - Alt approach - @kevin940726
• Library - make pattern title clickable #51898 - @getdave
• Make Pattern title text clickable for 6.3 release #52599
• Template Part renaming modal doesn't not decode entities #52419 - PR @t-hamano
• add sync tooltip #52458
• Site Editor: Don't allow creating template part on the Patterns page for non-block themes #52656
• Snackbar notices don't stay anchored to bottom of Patterns page
• Block Inserter: Error displayed in browser console when opening custom pattern categories - PR @glendaviesnz @talldan
• Custom Pattern: Each time you switch pattern categories, the number of custom patterns increases - PR @glendaviesnz @talldan
• Patterns: remove ability to change sync state in UI with a classic theme - PR - @glendaviesnz
• Pattern block: Rename "Convert to regular block" to "Unsync" - PR @richtabor
• Move the sync_status field to top level post field
• Should we rename sync_status to wp_sync_status? - question asked here. Looks like we are too late to consider this as 16.1 already out with existing naming.
• [Unsynced patterns created in site editor not appearing in post inserter]
• Patterns: Add handling of sync status to the wp-admin patterns list page #52346
• Import and export of patterns does not take into account sync status - PR - @glendaviesnz
• Import notice is incorrect - PR - @glendaviesnz
• Patterns: stop endless snackbars appearing #52012
• Patterns: update block description based on sync status/optionality - PR - @glendaviesnz
• Patterns: remove "apply globally" option from block settings #52139 - PR
• Renaming Reusable Blocks Should Still Be Discoverable #52194
• Patterns: Theme patterns without Categories do not show in Library #52614
• Patterns: add a hint about the rename of reusable blocks to menu and inserter  #51771
• Adding pattern from wp-admin page gives no option to add sync status - PR - @glendaviesnz
  • This might be something that has to wait until post 6.4, the PoC proved we could rely on the summary panel to present the modal.
• Update locked pattern tooltips #52497
• Try: Sticky header and pagination on Patterns page #52663
• Fix empty general template parts in Patterns #52747
• Command Palette: Update label and icon for Patterns #52742
• Patterns: Reinstate template parts mode spec #52780
• Library: Browser scrollbar blinks at certain browser width
• Command Center: 'Manage all my patterns' leads to WP Admin #52491 - PR
• Patterns: Align height of save button and patterns pagination #52764
• Patterns: Reset current page when search filters change #52933
• Patterns: Allow orphaned template parts to appear in general category #52961

Closed

• Library: Update section headings in pattern grid to account for template parts #51985

Future Follow-ups

• Make lock icons more consistent between theme patterns in the site editor page and the "Lock" menu item from the block toolbar's more menu
• Add nicely designed empty state explaining how to use patterns for when default category is empty
• Custom patterns: Library and Inserter 1:1
  • Needs design / Pending feedback
  • We could still get a draft PR together that includes synced patterns alongside unsynced patterns
• Add import/export for patterns to the Patterns library
• Patterns: Explore options to enforce pattern name uniqueness #52360
• Site Editor: Consider compatibility regarding non-block themes and the Library menu #52150
• Allow non-block themes with template parts support to create custom template parts in the Site Editor #51099
• Command Palette: consider nudge to patterns when searching for reusable blocks #52137
• Duplicating templates and patterns in the site editor #52107 - Different to 51919 by adding to pattern/template sidebar nav screen
• Patterns: use correct icon when searching with the slash inserter have suggested we push this to post 6.3. The current behaviour is by design so an enhancement and not a bug - should be reviewed but not critical enough to prioritise for 6.3
• Patterns: prevent Classic Block from being dragged into a Sync Pattern Block #52132
• Patterns: make the synced patterns purple the quick inserter list #53209 - PR

[jasmussen]

As a followup to #51939, and based on the designs attached for that, one thing we could do is add a little lock icon with a tooltip for theme patterns, indicating that they are not editable in the library:

[kevin940726]

@jasmussen I created #51990 for this!

[ndiego]

I believe #52101 needs to be added to this list.

[annezazu]

Offering up #52137 and #52139 for consideration

[t-hamano]

I believe #51295 is no longer reproduced in WordPress 6.3 and the latest Gutenberg, so I have closed it. Please see this comment.

[t-hamano]

I added #52107 because I think it is partially related to this tracking issue.

[pablohoneyhoney]

Would it make sense to connect a bit better the lock icon identifiers? #51771 (comment)

[colorful-tones]

#52614 might need to be added to this list. @ndiego @annezazu

[aaronrobertshaw]

As the 6.3 release cycle is coming to a close, it's time to close this tracking issue. Anything left outstanding will continue to be addressed through follow-ups for 6.4, or a 6.3.1 point release if required.

A huge thanks to everyone that helped in the effort to improve pattern management in time for 6.3! 🙇

[aaronrobertshaw]

A project has been created to track follow-up efforts for patterns: https://github.com/orgs/WordPress/projects/129

[bvlgn]

A project has been created to track follow-up efforts for patterns: https://github.com/orgs/WordPress/projects/129

I get a 404.
Is that link correct?

[annezazu]

Ah the project is accidentally private. @aaronrobertshaw I tried to update the project to be public but found I can only close it. Perhaps we need to recreate and have it public from the start or you might be able to see more settings here: https://github.com/orgs/WordPress/projects/129/settings

[glendaviesnz]

It should be public now hopefully.

[aaronrobertshaw]

Apologies for missing that @bvlgn & @annezazu.

Thanks @glendaviesnz for tweaking the project's visibility 👍