Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Patterns: Allow renaming and duplication within the Site Editor #51919

Closed
t-hamano opened this issue Jun 26, 2023 · 3 comments · Fixed by #52270
Closed

Custom Patterns: Allow renaming and duplication within the Site Editor #51919

t-hamano opened this issue Jun 26, 2023 · 3 comments · Fixed by #52270
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.

Comments

@t-hamano
Copy link
Contributor

What problem does this address?

In the Library menu of the site editor, you can create custom patterns.

create-pattern

However, in the site editor, you can only delete a pattern you have created.

delete

To rename, the following operation is required.

  • Click "Manage all custom patterns"
  • Edit a post(pattern)
  • Change the post title(pattern name)
  • Save the post(pattern)
  • Back to the Site Editor

What is your proposed solution?

It would be nice to be able to rename and even duplicate pattern names in the site editor, as in the navigation menu.

navigation

rename

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 26, 2023
@annezazu
Copy link
Contributor

Noting that I just ran into this with 16.1 RC1 and it's not clear to me where/how we can rename, except by adding the pattern and renaming it from there:

rename.mov

To me, the more important piece is renaming rather than duplication right now for 6.3. Adding to the triage board for consideration.

@richtabor
Copy link
Member

it's not clear to me where/how we can rename, except by adding the pattern and renaming it from there:

Which is very odd; unexpected even. I'd say that renaming control probably shouldn't exist at the pattern block level. I wouldn't expect to be able to change the title of this pattern from any instance; it's disconnected from where I manage/see all my patterns.

For additional context:

CleanShot 2023-06-26 at 16 58 53

@talldan
Copy link
Contributor

talldan commented Jun 28, 2023

Related a11y issue - Library: revisit keyboard navigation for pattern items

Another related observation is that template part actions (like 'Clear customizations') could be made available in the Library.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 4, 2023
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.3.x Editor Tasks Jul 7, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants