Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pattern block: "Manage Patterns" to open the Library > Custom patterns #51944

Closed
richtabor opened this issue Jun 26, 2023 · 6 comments · Fixed by #52403
Closed

Pattern block: "Manage Patterns" to open the Library > Custom patterns #51944

richtabor opened this issue Jun 26, 2023 · 6 comments · Fixed by #52403
Assignees
Labels
[Block] Pattern Affects the Patterns Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

richtabor commented Jun 26, 2023

If supported, instead of navigating to /wp-admin/edit.php?post_type=wp_block, it would be nice if this control opened the new Library within /wp-admin/site-editor.php?path=%2Flibrary.

Perhaps "Open Library"?

CleanShot 2023-06-26 at 17 05 21 CleanShot 2023-06-26 at 17 07 45
@richtabor richtabor added Needs Design Feedback Needs general design feedback. [Block] Pattern Affects the Patterns Block labels Jun 26, 2023
@richtabor richtabor changed the title Pattern block: "Manage Patterns" to open the Library > Custom patterns view Pattern block: "Manage Patterns" to open the Library > Custom patterns Jun 26, 2023
@ndiego ndiego added the [Type] Enhancement A suggestion for improvement. label Jun 27, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jun 27, 2023
@jasmussen
Copy link
Contributor

I could go with either "Manage patterns" or "Open library", though would be good to check the capitalization. It should be sentence case but I think there are some cases around proper nouns.

@richtabor
Copy link
Member Author

I could go with either "Manage patterns" or "Open library",

Let's roll with "Open library".

@aaronrobertshaw
Copy link
Contributor

Just noting here that we're likely renaming "Library" to "Patterns", so perhaps we stick with "Manage patterns" after all. (#52042)

@richtabor
Copy link
Member Author

richtabor commented Jun 29, 2023

Works for me; we just need to fix the capitalization then (alongside the change in path).

@carlomanf
Copy link

This issue reminds me of https://core.trac.wordpress.org/ticket/54908, which got fixed by removing the edit.php screen altogether for templates and template parts. Perhaps the same treatment could be considered for reusable blocks now. While reusable blocks have long been available through edit.php and removing it would upset some users, it should also be noted that the screen does not include "unsynced" patterns and would cause some associated confusion. A similar issue was reported with #35994 and abandoned because it was too hard to fix.

@aaronrobertshaw
Copy link
Contributor

I have an alternate solution up in #52403 which will allow us to conditionally direct users to where most appropriate for the time being.

We can explore the removal of the edit.php screen if desired after 6.3. That would afford us some additional time to communicate well to the users that might be negatively impacted by the change.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Pattern Affects the Patterns Block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
No open projects
6 participants