Patterns: update the title of Pattern block in the block inspector card #52010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glendaviesnz
added
Backport to WP 6.7 Beta/RC
92 tasks
glendaviesnz
added
[Type] Enhancement
|
Size Change: +13 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
carolinan
approved these changes
Jun 28, 2023
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
talldan
requested changes
Jun 28, 2023
|
cc @WordPress/gutenberg-design 🙏 |
|
Since this is a synced pattern, shouldn't we display the pattern name here, as we do with template parts? 
That would be my expectation. |
priethor
removed
Backport to Gutenberg RC
Comment on lines
46
to
49
| // As with Navigation block it's not ideal having Pattern block specific code here, but only synced patterns are selectable in the editor | ||
| // currently and finding the sync status higher up involves a call to the core-data store which isn't allowed in the block editor. | ||
| const blockTitle = | ||
| title === __( 'Pattern' ) ? __( 'Synced Pattern' ) : title; |
There was a problem hiding this comment.
Is updating the useBlockDisplayInformation hook an option so the BlockCard just gets passed the appropriate title?
We already check there if the current block type is a reusable block or template part, so it might not be a stretch to assign the pattern's name to the title property there as well.
There was a problem hiding this comment.
Yeh, that is what I was planning to do, will try and get back to it today.
glendaviesnz
added
the
Backport to WP 6.7 Beta/RC
|
Works as expected. GTG pending code review.
|
|
As a side note, that block description needs updating as well. Should probably reference "pattern" instead of "block". |
glendaviesnz
requested review from
ryanwelcher,
juanmaguitar and
fabiankaegy
as code owners
…cate the sync status
glendaviesnz
force-pushed
the
add/sync-type-to-inspector-block-card
branch
from
ce6c332 to
9ff50d8
Compare
ramonjd
approved these changes
Jul 11, 2023
| const { getBlockType, getActiveBlockVariation } = | ||
| select( blocksStore ); | ||
| const blockName = getBlockName( clientId ); | ||
| const blockType = getBlockType( blockName ); | ||
| if ( ! blockType ) return null; | ||
| let title = blockType.title; |
There was a problem hiding this comment.
Will the title property always be present on the object?
| const isSynced = | ||
| isReusableBlock( blockType ) || isTemplatePart( blockType ); | ||
| const isReusable = isReusableBlock( blockType ); | ||
| if ( isReusable ) { |
There was a problem hiding this comment.
Totally optional, but maybe this condition could be rejigged a bit.
blockType.title is already assigned to the title var.
What about
const resusableTitle = isReusableBlock( blockType ) ? __experimentalGetReusableBlockTitle( attributes.ref ) : '';
const title = resusableTitle || blockType?.title;There was a problem hiding this comment.
Seemed like the ternary needed to be set to undefined not '' if not reusable, but maybe I am missing something, eg.
const resusableTitle = isReusable ? __experimentalGetReusableBlockTitle( attributes.ref ) : undefined;
const title = resusableTitle || blockType.title;also on line 79 the function returns early if blockType is not defined, so the optional chaining is not needed for blockType.title - but have otherwise made that change as it is a bit tidier if you want to double check it @ramonjd
There was a problem hiding this comment.
Seemed like the ternary needed to be set to undefined not '' if not reusable, but maybe I am missing something
Sounds good. My example was "unrehearsed".
I retested and it works as advertised. Thanks @glendaviesnz !
|
Flaky tests detected in 3e92024. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5526009438
|
|
I just cherry-picked this PR to the update/first-batch-pre-RC1 branch to get it included in the next release: 90fbe99 |
tellthemachines
removed
the
Backport to WP 6.7 Beta/RC
westonruter
added a commit
that referenced
this pull request
Jul 12, 2023
…dd/defer-script-loading-strategy * 'trunk' of https://github.com/WordPress/gutenberg: Update Changelog for 16.2.0 Adding support for defined IDs in `TextControl` component (#52028) Bump plugin version to 16.2.0 Revert "Bump plugin version to 16.2.0" Bump plugin version to 16.2.0 Add maxLength to LinkControl search items (#52523) [RNMobile] Update Editor block inserter button styles and default text input placeholder/selection styles (#52269) Site Editor: Reset device preview type when exiting the editing mode (#52566) Trim footnote anchors from excerpts (#52518) Add back old Navigation and File blocks JavaScript implementation when Gutenberg is not installed (#52553) Block Editor: Ensure synced patterns are accounted for in 'getAllowedBlocks' (#52546) Fix md5 class messed up with new block key (#52557) Fix entity cache misses for single posts due to string as recordKey (#52338) Make "My patterns" permanently visible (#52531) Hide site hub when resizing frame upwards to avoid overlap (#52180) Fix "Manage all patterns" link appearance (#52532) Update navigation menu title size & weight in detail panels (#52477) Site Editor Patterns: Ensure sidebar does not shrink when long pattern titles are used (#52547) Site Editor: Restore quick inserter 'Browse all' button (#52529) Patterns: update the title of Pattern block in the block inspector card (#52010)
tellthemachines
added a commit
that referenced
this pull request
Jul 14, 2023
* Site Editor: Restore quick inserter 'Browse all' button (#52529) * Site Editor: Restore quick inserter 'Browse all' button * Remove leftover comment * Patterns: update the title of Pattern block in the block inspector card (#52010) * Site Editor Pages: load the appropriate template if posts page set (#52266) * This commit: - links the posts page to the homepage template when a post page is set - abstracts logic to get page item props * The Posts Page resolves to display the Home or Index template only. Adding a check to skip the Front Page * Showing homepage settings for posts pages that are set as the post page in reading settings * Post pages that have been set to display posts will redirect to first the home template, then the index template. The fallback is the post id of the page. * Reverted refactor of packages/edit-site/src/components/sidebar-navigation-screen-page/index.js Will do it in a follow up * Allow editing existing footnote from formats toolbar (#52506) * Block Editor: Display variation icon in the 'BlockDraggable' component (#52502) * Patterns: add option to set sync status when adding from wp-admin patterns list (#52352) * Show a modal to set sync status if adding pattern from pattern list page * Make sure the modal loads if post settings panel not open * don't load modal component at all if not new post * Simplify the sync status so undefined always = synced * Update packages/editor/src/components/post-sync-status/index.js --------- Co-authored-by: Ramon <ramonjd@users.noreply.github.com> * Revise LinkControl suggestions UI to use MenuItem (#50978) * Use "link" instead of "URL" for URL_TYPE * Use MenuItem for search create button * Use sentence case for "Create page" * Use a MenuGroup for search results * Use MenuItem for search item * Refactoring styles (WIP) * Preserve whitespace in results text * Reinstate result item information including permalink * Remove debugging CSS code * Reinstate CSS to control size of rich previews favicon * Remove other commented out CSS code * Reinstate selected styles * Remove more redundant CSS * Add some basic results hover/focus styling. Needs improving * Improve icon alignment * Update tests to handle wording changes * Remove inconsistent hover/focus style MenuItem already has hover/focus styles * Reinstate is-selected visual state * Update test to make sense in context of #51011 See #51011 * Fix locator for result text --------- Co-authored-by: Dave Smith <getdavemail@gmail.com> * Fix LinkControl mark highlight to bold (#52517) * Add 'reusable' keyword to Pattern blocks (#52543) * Fix missing Add Template Part button in Template Parts page (#52542) * Tweak copy for the reusable block rename hint (#52581) * Trim footnote anchors from excerpts (#52518) * Trim footnote anchors from excerpts * Add comments, fix spacing, appease linter * Site Editor: Reset device preview type when exiting the editing mode (#52566) * Make "My patterns" permanently visible (#52531) * Hide site hub when resizing frame upwards to avoid overlap (#52180) * Fix "Manage all patterns" link appearance (#52532) * Fix "Manage all patterns" link * Update focus style * Update navigation menu title size & weight in detail panels (#52477) * Update menu title size * Adjust font weight * Site Editor Patterns: Ensure sidebar does not shrink when long pattern titles are used (#52547) * Edit Site: Select templateType from the store inside the useSiteEditorSettings hook (#52503) * Add width to ensure ellipsis is applied (#52575) * Cover Block: Fix block deprecation when fixed background is enabled (#51612) * ResizableFrame: Make keyboard accessible (#52443) * ResizableFrame: Make keyboard accessible * Fix outline in Safari * Use proper CSS modifier * Add aria-label to button * Keep handle enlarged when resizing (Safari) * Add back visually hidden help text * Don't switch to edit mode * Make the handle a role="separator" * Revert to `button` * Switch description text to `div hidden` * Prevent keydown event default when right/left arrow * Change minimum frame width to 320px * Mention shift key in description text * Only render resize handle when in View mode * Fix importing classic menus (#52573) * use the same create hook for classic import * Remove redundant arg to hook --------- Co-authored-by: Dave Smith <getdavemail@gmail.com> * Site Editor: Fix navigation menu sidebar actions order and label (#52592) * Avoid errors in Dimension visualizers when switching between iframed and non-iframed editors (#52588) * Patterns: Add client side pagination to patterns list (#52538) Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com> * Site Editor: Make sidebar back button go *back* instead of *up* if possible (#52456) * Navigator: Add replace option to goTo() and goToParent() * Site Editor: Make sidebar back button go back instead of up if possible * Adapt template part hint copy (#52527) * Try "panel" instead of "page" * Update template-part-hint.js --------- Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com> Co-authored-by: Ramon <ramonjd@users.noreply.github.com> Co-authored-by: Miguel Fonseca <150562+mcsf@users.noreply.github.com> Co-authored-by: Rich Tabor <hi@richtabor.com> Co-authored-by: Dave Smith <getdavemail@gmail.com> Co-authored-by: Robert Anderson <robert@noisysocks.com> Co-authored-by: James Koster <james@jameskoster.co.uk> Co-authored-by: Andrew Serong <14988353+andrewserong@users.noreply.github.com> Co-authored-by: arthur791004 <arthur.chu@automattic.com> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: Lena Morita <lena@jaguchi.com> Co-authored-by: Andrei Draganescu <me@andreidraganescu.info> Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the title of Pattern block in the block inspector card to show the block title instead of generic
Patternstitle to match handling of template parts.Why?
Currently only synced patterns can be selected in the editor so indicates to the user the type of pattern they are currently viewing.
Fixes: #51922
How?
Detects a block of type resuable and uses the entity title instead of title from block settings.
Testing Instructions
Screenshots or screencast