Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] Block context is reflected in the preview #48826

Open
github-actions bot opened this issue Mar 7, 2023 · 1 comment · Fixed by #52513
Open

[Flaky Test] Block context is reflected in the preview #48826

github-actions bot opened this issue Mar 7, 2023 · 1 comment · Fixed by #52513
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Mar 7, 2023 •
edited
Loading

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

Block context is reflected in the preview

Test path

/test/e2e/specs/editor/plugins/block-context.spec.js

Errors

[2023-03-07T12:01:03.509Z] Test passed after 2 failed attempts on try/dedicated-block-controls-filter.
[2023-07-10T17:00:18.296Z] Test passed after 1 failed attempt on trunk.
[2023-07-10T19:48:45.141Z] Test passed after 1 failed attempt on try/deprecate-fonts-api.
[2023-07-10T23:30:43.635Z] Test passed after 1 failed attempt on trunk.
[2023-07-10T23:40:13.514Z] Test passed after 1 failed attempt on add/patterns-list-sync-status.
[2023-07-11T01:00:56.236Z] Test passed after 1 failed attempt on trunk.
[2023-07-11T07:15:36.697Z] Test passed after 1 failed attempt on update/pattern-post-type-edit-item-label.
[2023-07-11T08:56:00.931Z] Test passed after 1 failed attempt on update/cover-background-label.
[2023-07-11T09:23:05.914Z] Test passed after 1 failed attempt on update/locked-pattern-tooltips.
[2023-07-11T09:29:19.696Z] Test passed after 1 failed attempt on update/post-navigation-link.
[2023-07-11T12:12:49.167Z] Test passed after 1 failed attempt on fix/initial-block-parsing.
[2023-07-11T13:16:35.666Z] Test passed after 1 failed attempt on experiment/extend-behaviors-settings.
[2023-07-11T15:23:12.673Z] Test passed after 1 failed attempt on trunk.
[2023-07-11T17:32:12.171Z] Test passed after 1 failed attempt on fix/footnotes-trim-from-excerpts.
[2023-07-11T17:41:23.841Z] Test passed after 1 failed attempt on update/show-more-intuitive-archive-titles-on-query-title-block.
[2023-07-11T18:23:19.573Z] Test passed after 1 failed attempt on fix/linkcontrol-mark.
[2023-07-11T21:31:05.700Z] Test passed after 1 failed attempt on fix-wp-data-promise-return-type.
[2023-07-11T23:46:51.761Z] Test passed after 1 failed attempt on fix-nav-colors.
[2023-07-12T00:25:46.190Z] Test passed after 1 failed attempt on add/sync-type-to-inspector-block-card.
[2023-07-12T01:10:02.574Z] Test passed after 1 failed attempt on trunk.
[2023-07-12T02:22:13.939Z] Test passed after 1 failed attempt on fix/remove-link-from-draft-page.
[2023-07-12T06:09:50.806Z] Test passed after 1 failed attempt on fix/get-allowed-blocks-selector.
[2023-07-12T06:26:46.948Z] Test passed after 1 failed attempt on update/empty-my-patterns-inserter.
[2023-07-12T06:28:04.856Z] Test passed after 1 failed attempt on fix/add-reusable-keyword-to-patterns.
[2023-07-12T09:19:25.496Z] Test passed after 1 failed attempt on fix/navigation-title-in-details.
[2023-07-12T09:40:31.950Z] Test passed after 1 failed attempt on fix/md5-class-messed-up-with-new-block-key.
[2023-07-12T10:31:04.567Z] Test passed after 1 failed attempt on trunk.
[2023-07-12T14:16:08.642Z] Test passed after 1 failed attempt on try/change-patterns-heading.
[2023-07-12T15:01:35.701Z] Test passed after 1 failed attempt on trunk.
[2023-07-12T15:02:12.131Z] Test passed after 1 failed attempt on trunk.
[2023-07-12T18:28:01.664Z] Test passed after 1 failed attempt on add-filter-to-switch-to-old-navigation-block-implementation.
[2023-07-12T18:44:16.156Z] Test passed after 1 failed attempt on tweak/reusable-block-notice.
[2023-07-12T21:18:08.516Z] Test passed after 1 failed attempt on fix/resizable-frame-keyboard.
[2023-07-13T00:13:09.735Z] Test passed after 1 failed attempt on fix/add-reusable-keyword-to-patterns.
[2023-07-13T00:41:04.096Z] Test passed after 1 failed attempt on fix-wp-data-promise-return-type.
[2023-07-13T06:13:33.047Z] Test passed after 1 failed attempt on update/patterns-list-pagination.
[2023-07-13T06:45:15.460Z] Test passed after 1 failed attempt on update/patterns-list-pagination.
[2023-07-13T11:31:20.204Z] Test passed after 1 failed attempt on rnmobile/update-mobile-toolbar-icons-and-color.
[2023-07-13T12:07:10.618Z] Test passed after 1 failed attempt on trunk.
[2023-07-13T13:22:25.831Z] Test passed after 1 failed attempt on add/ariakit-tabs.
[2023-07-13T13:29:02.965Z] Test passed after 1 failed attempt on trunk.
[2023-07-13T13:44:46.907Z] Test passed after 1 failed attempt on a11y/site-editor-dropdown-delete.
[2023-07-13T14:56:45.415Z] Test passed after 1 failed attempt on trunk.
[2023-07-13T15:36:32.227Z] Test passed after 1 failed attempt on release/16.2.
[2023-07-13T15:49:15.200Z] Test passed after 1 failed attempt on release/16.2.
[2023-07-13T16:25:16.048Z] Test passed after 1 failed attempt on search/remove-use-effect.
[2023-07-13T18:11:57.120Z] Test passed after 1 failed attempt on trunk.
[2023-07-13T20:05:44.684Z] Test passed after 1 failed attempt on fix/52411-kebab-case.
[2023-07-13T20:12:20.210Z] Test passed after 1 failed attempt on fix/toolbar-shift-tab.
[2023-07-13T20:31:07.956Z] Test passed after 1 failed attempt on experiment/extend-behaviors-settings.
[2023-07-14T02:28:34.651Z] Test passed after 1 failed attempt on update/first-batch-pre-RC1.
[2023-07-14T05:37:08.786Z] Test passed after 1 failed attempt on add/text-orientation.
[2023-07-17T06:08:33.331Z] Test passed after 1 failed attempt on do/restore-nux-wp63.
[2023-07-17T06:47:38.643Z] Test passed after 1 failed attempt on wp/6.3.
[2023-07-31T17:19:19.217Z] Test passed after 1 failed attempt on add/sync-php-signaling.
[2023-08-08T08:30:18.104Z] Test passed after 1 failed attempt on add/commands-data-docs.
[2024-12-05T17:54:04.263Z] Test passed after 1 failed attempt on fix/Docs-Fix-Playwright-Page-Object-Model-link.
[2024-12-24T03:29:51.157Z] Test passed after 1 failed attempt on block-pattern-meta-box. 
Error: apiRequestContext.fetch: socket hang up
Call log:
  - → PUT http://localhost:8889/index.php?rest_route=/wp/v2/plugins/gutenberg-test-plugins/block-context
  -   user-agent: Playwright/1.48.1 (x64; ubuntu 22.04) node/20.18 CI/1
  -   accept: */*
  -   accept-encoding: gzip,deflate,br
  -   X-WP-Nonce: ad6b5893e5
  -   content-type: application/json
  -   content-length: 21
  -   cookie: wordpress_test_cookie=WP%20Cookie%20check; wordpress_logged_in_23778236db82f19306f247e20a353a99=admin%7C1735182894%7Cza26ggzj09VR5qRCv7sHuvlyht1fzhpQESt0KO0Tp9O%7Ce595021c2e081c8e638caa31ffc6cf42e2d424a5748476c1e5ffbf93c5e86bb5; wp-settings-time-1=1735010165

    at RequestUtils.rest (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/rest.ts:119:39)
    at RequestUtils.deactivatePlugin (/home/runner/work/gutenberg/gutenberg/packages/e2e-test-utils-playwright/src/request-utils/plugins.ts:96:13)
    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/editor/plugins/block-context.spec.js:16:3
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Mar 7, 2023
@github-actions github-actions bot mentioned this issue Mar 7, 2023
Closed
@github-actions github-actions bot reopened this Jul 10, 2023
github-actions bot referenced this issue Jul 10, 2023
@t-hamano
[RNMobile] Fix Fixed warning in clean script (#52447)
1f82e3f
@github-actions github-actions bot mentioned this issue Jul 10, 2023
Merged
github-actions bot referenced this issue Jul 10, 2023
@jameskoster
Update descriptions (#52468)
05f75a9
@github-actions github-actions bot mentioned this issue Jul 10, 2023
Merged
github-actions bot referenced this issue Jul 11, 2023
@gutenbergplugin
Bump plugin version to 16.2.0-rc.3
b802534
This was referenced Jul 11, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@Mamaduka Mamaduka mentioned this issue Jul 11, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 11, 2023
github-actions bot referenced this issue Jul 11, 2023
@t-hamano
Theme JSON schema: Add missing block names and unify block properties (…
98c01fd 
…#51293)
This was referenced Jul 11, 2023
Merged
Merged
Merged
@github-actions github-actions bot reopened this Jul 11, 2023
This was referenced Jul 11, 2023
Merged
Merged
Merged
github-actions bot referenced this issue Jul 12, 2023
@glendaviesnz
Patterns: update the title of Pattern block in the block inspector ca…
fa85e95 
…rd (#52010)
This was referenced Jul 12, 2023
Closed
Merged
This was referenced Jul 13, 2023
Merged
Merged
github-actions bot referenced this issue Jul 13, 2023
@Mamaduka
Site Editor: Fix navigation menu sidebar actions order and label (#52592
4dad152 
)
@github-actions github-actions bot mentioned this issue Jul 13, 2023
Merged
github-actions bot referenced this issue Jul 13, 2023
@draganescu @getdave
Fix importing classic menus (#52573)
032b261 
* use the same create hook for classic import

* Remove redundant arg to hook

---------

Co-authored-by: Dave Smith <getdavemail@gmail.com>
@github-actions github-actions bot mentioned this issue Jul 13, 2023
Merged
github-actions bot referenced this issue Jul 13, 2023
@MaggieCabrera @jeryj @scruffian
Nav block: link text color inheritance fixes and tests (#51710)
033c5e3 
* tests and fix for link color inheritance

* test agains emptytheme too, refactor setup, added better comments

* change setup for tests

* removed inherit color for the moment on the block

* finished the first test with all cases

* finished second test

* finished third test

* started the last test

* spacing on comments

* removed unnecessary actions from before/after testing functions

* insert specific id of nav directly to speed up things

* finish checking colors in the editor on desktop

* test the overlay and reset settings

* use variables for colors, cover rest of the cases to test

* introduced a third link to cover non submenu links

* undo unwanted change

* finish the overlay background tests and fix issues with inheritance

* turn colors into variables for readibility

* fix wrong color syntax

* Create test page before creating navigation menu

* Add test coverage for selecting group text color that should be inherited by all links

This test is currently failing. TDD.

* Fix incorrect selector structure.

The &:where(.wp-block-navigation-item a) rule would never apply, as .wp-block-navigation__responsive-container would never also have a .wp-block-navigation-item class on it. Adding the space allows it to apply the inherit rule to the a tag.

* Update tests to check for black text defaults on navigation links

* Big refactor of navigation color tests

* Changed link names from non-descriptive firstLink, secondLink, and thirdLink to clearer names: customLink, submenuLink, and pageLink.
* Combined some repeated operations such as openEditorOverlay, openFrontendOverlay, and resetGlobalStyles
* Added ColorControl for keeping track of all the link selectors

* Revert link color settings changing the navigation link colors

The trunk behavior is to have text color global styles change the navigation color styles, while the global link color styles do not change the navigation colors. Also updated the tests to not have any of those color changes impact the submenus.

* Large refactor of navigation color tests

It was getting difficult to work within several very long tests with a lot of shared code, so I refactored into shared pieces that would make writing the tests easier while keeping debugging easy as well.

Also, one large change was to remove the reliance on global styles since resetting the global styles after a failed test was proving very difficult, and we don't need to use global styles since we can rely on creating a group instead. By wrapping a group on the navigation block we can test the same thing while not needing to deal with global styles.

* Add test for navigation background colors

Also added closing the sidebar in the tests so we don't accidentally grab the links from the sidebar when the navigation block has the sidebar menu open with the same link text.

* Add test to ensure navigation text does not inherit link color from the theme/group

* Only set default navigation submenu and overlay text colors if no navigation text color is selected

* Have li navigation items inherit background color so it can be inherited by the submenu background

* Change how to test editor mobile overlay colors

The tests were a little flaky when tryingn to click the button to open the mobile view since the animation from desktop to mobile in the editor took some time, and the test was trying to click the open menu button before it was able to be clicked.

This updates the test to use the navigation settings itself, which doesn't have an animation, so it should be more reliable.

* Move navigation color tests to own file

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

* update comments

* Update test/e2e/specs/editor/blocks/navigation-colors.spec.js

---------

Co-authored-by: Jerry Jones <jones.jeremydavid@gmail.com>
Co-authored-by: Ben Dwyer <ben@scruffian.com>
github-actions bot referenced this issue Jul 13, 2023
@gutenbergplugin
Bump plugin version to 16.2.1
05e9a76
github-actions bot referenced this issue Jul 13, 2023
@gutenbergplugin
Update Changelog for 16.2.1
3f2e6af
@github-actions github-actions bot mentioned this issue Jul 13, 2023
Merged
github-actions bot referenced this issue Jul 13, 2023
@westonruter @luisherranz
Add filter to turn off Interactivity API for a block (#52579)
b690db2 
* Add filter to turn off Interactivity API for a block

* Dynamically opt-in to interactivity support in File and Navigation blocks

Co-authored-by: Luis Herranz <luisherranz@gmail.com>
This was referenced Jul 13, 2023
Merged
Merged
Merged
Closed
Merged
github-actions bot referenced this issue Jul 17, 2023
@peterwilsoncc
chore(release): publish
57ab3bd 
 - @wordpress/base-styles@4.26.3
 - @wordpress/e2e-tests@7.6.8
 - @wordpress/nux@7.1.0
 - @wordpress/postcss-plugins-preset@4.19.3
 - @wordpress/scripts@26.6.3
@github-actions github-actions bot mentioned this issue Jul 31, 2023
Closed
@github-actions github-actions bot mentioned this issue Aug 8, 2023
Merged
@github-actions
Copy link
Author

github-actions bot commented Sep 8, 2023

This issue has gone 30 days without any activity.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Sep 8, 2023
@Mamaduka Mamaduka closed this as completed Sep 8, 2023
@github-actions github-actions bot reopened this Dec 5, 2024
@github-actions github-actions bot mentioned this issue Dec 5, 2024
Merged
@Mamaduka Mamaduka removed [Status] In Progress Tracking issues with work in progress [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. labels Dec 5, 2024
@Mamaduka Mamaduka removed their assignment Dec 5, 2024
@Mamaduka Mamaduka closed this as completed Dec 5, 2024
@github-actions github-actions bot reopened this Dec 24, 2024
@github-actions github-actions bot mentioned this issue Dec 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try fixing block context e2e test failure WordPress/gutenberg
1 participant
@Mamaduka