Restore @wordpress/nux to WP 6.3 branch
#52454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.45 MB ℹ️ View Unchanged
|
This was referenced Jul 10, 2023
peterwilsoncc
requested review from
spacedmonkey,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
peterwilsoncc
force-pushed
the
do/restore-nux-wp63
branch
from
bf529fe to
3740cca
Compare
|
Flaky tests detected in b03f036. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5572180944
|
tellthemachines
approved these changes
Jul 17, 2023
|
The Puppeteer 2 and 3 tests are failing in the most recent wp/6.3 run too.
I'm presuming some general flakiness. |
This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php
The addition of the transforms of 0 pixels can be added safely as they have no effect.
peterwilsoncc
force-pushed
the
do/restore-nux-wp63
branch
from
dcb1d00 to
b03f036
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #46110 in the WordPress 6.3 branch. See #52444.
See also:
@wordpress/nuxto WP 6.2 branch #52452 -- Equivalent for WP 6.2 branch@wordpress/nuxto trunk #52455 -- Equivalent for trunkWhy?
As the WordPress-Develop is still consuming the package, this is causing significant issues while running npm run sync-gutenberg-packages for both the wp-6.2 and wp-6.3 distribution tags.
While the script is apparently successful, the incorrect versions of key packages are installed. @wordpress/components reverts to version 23.9.0; @wordpress/data reverts to 8.6.0.
Tagging @wordpress/nux@6.0.0 with the affected distribution tags has been attempted without success, see WP#57643 (comment).
How?
Testing Instructions
npm igit checkout package-lock.jsonif requirednpm distclean; npm clean:packagespackages/nuxdon't existnpm buildpackages/nuxhave been creatednpm run docs:buildLerna dry run: TBA
Testing Instructions for Keyboard
N/A -- code change only
Screenshots or screencast