Restore @wordpress/nux to trunk
#52455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 10, 2023
peterwilsoncc
changed the title
@wordpress/nux to trunk
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
|
Flaky tests detected in 074490e9c5849306ec098d2aaa8617ac08bc12fe. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5548562185
|
peterwilsoncc
requested review from
spacedmonkey,
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
peterwilsoncc
force-pushed
the
do/restore-nux-trunk
branch
from
328eee5
to
def50c5
Compare
tellthemachines
approved these changes
Jul 17, 2023
peterwilsoncc
force-pushed
the
do/restore-nux-trunk
branch
2 times, most recently
from
6a61021
to
c4b3dc2
Compare
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/client-assets.php |
This reverts commit 9ea80f6. # Conflicts: # lib/client-assets.php
The addition of the transforms of 0 pixels can be added safely as they have no effect.
peterwilsoncc
force-pushed
the
do/restore-nux-trunk
branch
from
c4b3dc2
to
16477d1
Compare
23 tasks
mburridge
added
[Type] Enhancement
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Reverts #46110 in trunk. See #52444.
See also:
@wordpress/nuxto WP 6.2 branch #52452 -- Equivalent for WP 6.2 branch@wordpress/nuxto WP 6.3 branch #52454 -- Equivalent for WP 6.3 branchWhy?
As the WordPress-Develop is still consuming the package, this is causing significant issues while running npm run sync-gutenberg-packages for both the wp-6.2 and wp-6.3 distribution tags.
While the script is apparently successful, the incorrect versions of key packages are installed. @wordpress/components reverts to version 23.9.0; @wordpress/data reverts to 8.6.0.
Tagging @wordpress/nux@6.0.0 with the affected distribution tags has been attempted without success, see WP#57643 (comment).
How?
Testing Instructions
npm igit checkout package-lock.jsonif requirednpm distclean; npm clean:packagespackages/nuxdon't existnpm buildpackages/nuxhave been creatednpm run docs:buildLerna dry run: TBA
Testing Instructions for Keyboard
N/A -- code change only
Screenshots or screencast