Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin: Synchronize PHP changes for WordPress 6.4 release #54177

Closed
86 tasks done
mikachan opened this issue Sep 5, 2023 · 35 comments
Closed
86 tasks done

Plugin: Synchronize PHP changes for WordPress 6.4 release #54177

mikachan opened this issue Sep 5, 2023 · 35 comments
Assignees
@karmatosed @mikachan @SiobhyB
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@mikachan
Copy link
Member

mikachan commented Sep 5, 2023 •
edited
Loading

The issue tracks changes to PHP files that (might) need to be backported and merged to Core for the WordPress 6.4 release. The list is exhaustive so it may cover multiple PRs and experimental changes that won't be in 6.4.

Beta 1 is September 26, 2023

Tips 👀

❗ This is a living document and will be constantly updated as we approach beta. Sorry if you were mistakenly pinged! If a file or files have already been backported, please tick them off and link to the backport PR/trac issue.

Or, if the changes are not slated for WordPress 6.4, you can strike them or make a comment in this issue. Thank you! 🙇

PRs to be backported will have the "Needs PHP backport" label applied.
Screenshot 2023-06-05 at 10 47 22 am

📁 lib

📄 blocks.php

📄 class-wp-duotone-gutenberg.php

📄 class-wp-rest-global-styles-controller-gutenberg.php

📄 class-wp-theme-json-gutenberg.php

📄 client-assets.php

📄 experiments-page.php

📄 load.php

📄 load.php

📄 theme.json

📁 block-supports

📁 background.php

📄 behaviors.php

📄 colors.php

📄 elements.php

📄 layout.php

📄 typography.php

📁 lib/compat/wordpress-6.4

📄 block-patterns.php

📄 blocks.php

📄 class-gutenberg-rest-global-styles-revisions-controller-6

📄 rest-api.php

📄 script-loader.php

📄 kses.php

📁 lib/experimental

📄 auto-inserting-blocks.php

📄 blocks.php

📄 class--wp-editors.php

📄 class-gutenberg-rest-block-patterns-controller.php

📄 class-gutenberg-rest-template-revision-count.php

📄 class-wp-rest-block-editor-settings-controller.php

📄 class-wp-rest-customizer-nonces.php

📄 disable-tinymce.php

📄 editor-settings.php

📄 kses.php

📄 rest-api.php

📄 synchronization.php

### 📁 lib/experimental/fonts-api
The Fonts API will not be backported to Core, as it's been deprecated in the plugin and replaced by Font Face.

#### 📄 fonts-api.php

📁 lib/experimental/fonts/font-library

📄 class-wp-font-library.php

📄 class-wp-font-family.php

📄 class-wp-font-family-utils.php

📁 fonts-library

📁 packages/style-engine

📄 packages/style-engine/class-wp-style-engine.php

📁 packages/block-serialization-default-parser

📄 class-wp-block-parser.php

📁 packages/block-library/

🚧 Contingent features

The following are features that may or may not be shipped with 6.4.
@mikachan mikachan added Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. labels Sep 5, 2023
@mikachan mikachan moved this to In Progress in WordPress 6.4 Editor Tasks Sep 5, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Sep 5, 2023

Thanks for the ping.

I just double-checked the core files, and there's no need to backport #54154. The autogenerated static blocks list looks correct for the core.

@mikachan
Copy link
Member Author

mikachan commented Sep 5, 2023

Thanks @Mamaduka! I'll check it off the list.

@tellthemachines
Copy link
Contributor

I've added Trac tickets/PRs above to my two changes to class-wp-theme-json-gutenberg.php. I think @oandregal 's off for the next week or so, so I'm happy to do PRs for his changes to the same file too!

@ramonjd
Copy link
Member

ramonjd commented Sep 6, 2023

Thanks for getting this together! I've added all the links to backport PRs/trac tickets for my changes.

Summary of updates

Try: bundle WP_REST_Global_Styles_Controller class instead of inheriting per WordPress version #53618 

Mostly a plugin-only refactor. A couple of code quality tweaks. Bundled these with #52819 and added backport links.

Patterns: add delete_posts to the wp_block (patterns) capabilities #53405 - @ramonjd | Trac ticket | Core backport PR (Is this going into WP 6.3.2?)

Not sure, but let's keep it here since everything is ready in case it can go into 6.4.

Date: add relative time translations for moment.js #53931

Done. Added links

Fluid typography: add min and max viewport width configurable options #53081

Done. Added links

Rest API: rename navigation fallback classes from WP_ to Gutenberg_ #51959 

Plugin only changes - removed

Template revisions API: move back to experimental #51774

I don't think this one is going make it. It's blocked:
https://core.trac.wordpress.org/ticket/57704#comment:4

I struck it out and left it there for visibility

@tyxla
Copy link
Member

tyxla commented Sep 6, 2023

Thanks for the ping! 🙌

I've taken a thorough look at my PRs and none of them need to be backported. They're all related to an experiment to deprecate TinyMCE which isn't ready for public use in core just yet.

@mikachan
Copy link
Member Author

mikachan commented Sep 6, 2023

Thanks @tyxla! I've put a strikethrough through your PRs.

@hellofromtonya
Copy link
Contributor

hellofromtonya commented Sep 6, 2023 •
edited
Loading

The Fonts API is deprecated and replaced by Font Face to work with the Font Library. Thus, the Fonts API found in lib/experimental/fonts-api/ will not be backported to Core. Plus these files will be removed from Gutenberg once the Font Library is turned on.

Description updated ✅

@ockham
Copy link
Contributor

ockham commented Sep 6, 2023 •
edited
Loading

I've started work on porting the PHP code for auto-inserting blocks (which have been recently renamed to "block hooks"). My (very early) WIP PR is here; I might have to break it down into smaller ones eventually.

(My only other change in the above list doesn't need any porting to Core, since it was a mere cleanup on the Gutenberg side to remove something that had already been ported to Core.

@youknowriad
Copy link
Contributor

For the sync package, I don't think there's anything to do at the moment as the usage of this package is behind an experimental flag still.

@michalczaplinski
Copy link
Contributor

I've updated all of my items and the ones for @c4rl0sbr4v0, as he's on parental leave.

@artemiomorales
Copy link
Contributor

Hi! We’re still working on the lightbox, so I’ll open the backports for the following once we merge this current PR.

@tellthemachines
Copy link
Contributor

And here's the PR for the remaining 2 theme json class changes: WordPress/wordpress-develop#5162

@aaronrobertshaw
Copy link
Contributor

I've added the Trac ticket and PR for the changes relating to:

@carolinan
Copy link
Contributor

Trac ticket for #50822 (writing mode)

@tellthemachines tellthemachines mentioned this issue Sep 14, 2023
Merged
@andrewserong
Copy link
Contributor

I've opened a Trac ticket and PR for the changes from:

@aaronrobertshaw
Copy link
Contributor

A Trac ticket and PR are available for the changes from:

@tellthemachines
Copy link
Contributor

I've opened a trac ticket (plus linked PR) for this bug I just fixed today 😄

@t-hamano
Copy link
Contributor

A Trac ticket and a patch are available for the changes from:

@t-hamano t-hamano mentioned this issue Sep 19, 2023
Merged
@michalczaplinski
Copy link
Contributor

I've created a Trac ticket and PR.

@spacedmonkey
Copy link
Member

This change will also need to backported - #51116

@Mamaduka
Copy link
Member

@spacedmonkey, I think Ari is already working on the core patch - WordPress/wordpress-develop#5244.

@aristath
Copy link
Member

@spacedmonkey, I think Ari is already working on the core patch - WordPress/wordpress-develop#5244.

Yep, trac ticket created in https://core.trac.wordpress.org/ticket/59405 👍

@michalczaplinski
Copy link
Contributor

As Behaviors have been removed from the plugin in #53851 and will not be shipping in 6.4, I marked the following as done:

@anton-vlasenko
Copy link
Contributor

The pull request #52696 doesn't need to be backported to Core. It's specific to Gutenberg.

@mikachan
Copy link
Member Author

@peterwilsoncc, could you please confirm if #52455 needs a backport ahead of Beta 1?

@spacedmonkey, could you please confirm if #52045 needs a backport ahead of Beta 1?

@peterwilsoncc
Copy link
Contributor

@peterwilsoncc, could you please confirm if #52455 needs a backport ahead of Beta 1?

@mikachan It does not, the NUX script and styles are already included in WP Core. I'll edit this ticket accordingly.

@mikachan
Copy link
Member Author

@getdave, I noticed that you approved #52045 - do you know if it needs a backport ahead of Beta 1?

@SiobhyB
Copy link
Contributor

SiobhyB commented Sep 25, 2023 •
edited
Loading

Status Update

I went through the remaining PRs labelled Needs PHP backport and closed those that had been backported. At the time of writing, the following 19 18 issues with the label are still pending.

Monitoring (on this issue's list)

New (not yet on this issue's list)

I'll go ahead to add the following to the main list on this issue, but also wanted to quickly list them here as a heads up for the authors.

@spacedmonkey
Copy link
Member

Add caching to schema of REST API. #52045 was committed in WordPress 6.3 - See WordPress/wordpress-develop@7faab12

@spacedmonkey
Copy link
Member

Block API: Unnecessary JSON decoding in block parser #54424 - Will be committed to core once the npm packages are updated in core.

@Mamaduka
Copy link
Member

Ticket and sync PR for - #54254

@spacedmonkey
Copy link
Member

Another backport issue - #54835 - Core ticket https://core.trac.wordpress.org/ticket/59453#ticket

@t-hamano
Copy link
Contributor

A Trac ticket and a patch are available for the changes from:

@mikachan mikachan mentioned this issue Sep 29, 2023
Merged
@dmsnell
Copy link
Member

dmsnell commented Sep 29, 2023

Added the links to the backport of Tag Processor usage in block supports layout; was merged into Core already in WordPress/wordpress-develop#5252

@carstingaxion carstingaxion mentioned this issue Oct 8, 2023
Open
@bph bph moved this from In Progress to Done in WordPress 6.4 Editor Tasks Oct 13, 2023
@mikachan
Copy link
Member Author

mikachan commented Nov 8, 2023

WP 6.4 has been released 🥳 So I'm going to close this. Thanks for everyone's input with the backports!

@mikachan mikachan closed this as completed Nov 8, 2023
@getdave getdave mentioned this issue Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karmatosed karmatosed

@mikachan mikachan

@SiobhyB SiobhyB

Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
No open projects
WordPress 6.4 Editor Tasks
Status: Done
Milestone
No milestone
Development

No branches or pull requests