Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync minor code quality tweaks to WP_REST_Global_Styles_Controller #5152

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Sep 6, 2023

For 6.4, sync a couple of minor code quality tweaks to the WP_REST_Global_Styles_Controller class.

  1. Remove unnecessary local variable in ::get_theme_items()
  2. Change ::validate_custom_css() access modifier from private to protected so that the method is inherited if the class is extended

Gutenberg PRs:

Trac ticket: https://core.trac.wordpress.org/ticket/59296


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@tellthemachines
Copy link
Contributor

Committed in r56575.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants