Template revisions API: move back to experimental

[ramonjd]

What?

This PR moves the PHP changes from:

• Add template revision button #45215 (code was originally in experimental)
• Fix: Multiple overwrites on rest_controller_class for wp_template/wp_template_part. #48078 (moved to 6.3)

from compat/6.3 into /experimental

Why?

Template revisions feature won't make it to 6.3 without a Core change

See discussion: #45215 (comment)

How?

Copy pasta

Testing Instructions

Check that the feature still works on Gutenberg, and that you can see the template revisions button after you change a template or template part (more than twice).

More detailed test steps in #45215

[ramonjd]

I kept the naming convention from #45215

Was considering Gutenberg_REST_Templates_Controller, but there are no other features here. Not sure.

[github-actions]

Flaky tests detected in 14cb1ddb4e1d618c2889318ee74c46e0d53c41cb.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5341138456
📝 Reported issues:

• [Flaky Test] Pick the additional variation in the inserted Columns block #47057 in specs/editor/plugins/block-variations.test.js

[ramonjd]

e2e fails are unrelated I think

https://core.trac.wordpress.org/ticket/58592#comment:6

[draganescu]

Thanks for this @ramonjd 🙇🏻 This tests well, I wonder why do we still need the code in the 6.3 folder and not only in experimental?

[ramonjd]

I wonder why do we still need the code in the 6.3 folder and not only in experimental?

Good question! Do you mean the lookup functionality and endpoint? Here's the PR that introduced it:

• Add: Modal to choose a start pattern on new templates. #46248

I just assumed it was separate to the revisions stuff and was indeed going into 6.3?

I could be wrong here, so please correct me 😄

[draganescu]

1. It seems Add: Modal to choose a start pattern on new templates. #46248 introduced features for 6.2.
2. It seems according to Chore: Move Gutenberg_REST_Templates_Controller from 6.2 to 6.3 compatibility. #48077 that whatever else other than revisions is in the 6.3 rest controller should land.
3. The revisions patch was moved from experimental to 6.3 by Fix: Multiple overwrites on rest_controller_class for wp_template/wp_template_part. #48078.
4. So we're moving them back to experimental.
5. So that means this PR is correct.

[ramonjd]

Thanks @draganescu

I appears that the changes to get_template_fallback are not yet in Core:

https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-templates-controller.php#L157

The /lookup endpoint exists in Core.

So I guess get_template_fallback from the following PR never made it into 6.2?

• Add: Modal to choose a start pattern on new templates. #46248

Was it deliberately left out of 6.2? I can't find any records.

Should it be backported to 6.3?

[github-actions]

Warning: Type of PR label error

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

• Type-related labels to choose from: [Type] Accessibility (a11y), [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core.
• Labels found: [Type] Task, [Feature] Templates API, [Type] Code Quality.

Read more about Type labels in Gutenberg.