Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caching to schema of REST API. #52045

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Add caching to schema of REST API. #52045

merged 1 commit into from
Jun 29, 2023

Conversation

spacedmonkey
Copy link
Member

What?

Improve performance of the REST API call by caching schema data. See ticket for more details - https://core.trac.wordpress.org/ticket/58657#ticket

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Copy link
Contributor

@kadamwhite kadamwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that missing piece, @spacedmonkey 👍

Copy link
Contributor

@getdave getdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for catching this 👍

For anyone's future reference this is documented at https://developer.wordpress.org/rest-api/extending-the-rest-api/schema/#caching-schema

@spacedmonkey spacedmonkey merged commit 76e03d7 into trunk Jun 29, 2023
@spacedmonkey spacedmonkey deleted the fix/schema-rest-api branch June 29, 2023 08:06
@github-actions github-actions bot added this to the Gutenberg 16.2 milestone Jun 29, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@priethor priethor added the [Type] Performance Related to performance efforts label Jul 14, 2023
@SiobhyB SiobhyB added the Needs PHP backport Needs PHP backport to Core label Sep 5, 2023
@getdave
Copy link
Contributor

getdave commented Sep 25, 2023

@spacedmonkey Can I confirm whether this change still needs backporting to Core for 6.4? Thank you.

@spacedmonkey
Copy link
Member Author

@getdave This ticket was resolved in the WP 6.3 release. See WordPress/wordpress-develop@7faab12

@SiobhyB SiobhyB removed the Needs PHP backport Needs PHP backport to Core label Sep 25, 2023
@getdave
Copy link
Contributor

getdave commented Sep 25, 2023

Thanks. I got a ping about it today re: 6.4 and so it's good to know it's already sorted. Thanks Jonny 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Performance Related to performance efforts
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants